Module Name: src
Committed By: dholland
Date: Fri Nov 19 09:08:26 UTC 2010
Modified Files:
src/sys/dev: kloader.c
Log Message:
add missing pathbuf_destroy on error path, noticed by enami
XXX: this code is wrong; it should not be calling namei and then
XXX: vn_open on the same nameidata.
To generate a diff of this commit:
cvs rdiff -u -r1.24 -r1.25 src/sys/dev/kloader.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/kloader.c
diff -u src/sys/dev/kloader.c:1.24 src/sys/dev/kloader.c:1.25
--- src/sys/dev/kloader.c:1.24 Fri Nov 19 06:44:39 2010
+++ src/sys/dev/kloader.c Fri Nov 19 09:08:26 2010
@@ -1,4 +1,4 @@
-/* $NetBSD: kloader.c,v 1.24 2010/11/19 06:44:39 dholland Exp $ */
+/* $NetBSD: kloader.c,v 1.25 2010/11/19 09:08:26 dholland Exp $ */
/*-
* Copyright (c) 2001, 2002, 2004 The NetBSD Foundation, Inc.
@@ -27,7 +27,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: kloader.c,v 1.24 2010/11/19 06:44:39 dholland Exp $");
+__KERNEL_RCSID(0, "$NetBSD: kloader.c,v 1.25 2010/11/19 09:08:26 dholland Exp $");
#include "debug_kloader.h"
@@ -607,6 +607,7 @@
error = vn_open(&nid, FREAD, 0);
if (error != 0) {
PRINTF("%s: open failed, errno=%d\n", filename, error);
+ pathbuf_destroy(pb);
return (NULL);
}
