Module Name: src
Committed By: pooka
Date: Fri Nov 19 17:46:02 UTC 2010
Modified Files:
src/tests/fs/vfs: t_vfsops.c
Log Message:
Convert skipped tests into proper xfails (a lazy bum is me).
prompted by pgoyette
To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/tests/fs/vfs/t_vfsops.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/tests/fs/vfs/t_vfsops.c
diff -u src/tests/fs/vfs/t_vfsops.c:1.7 src/tests/fs/vfs/t_vfsops.c:1.8
--- src/tests/fs/vfs/t_vfsops.c:1.7 Mon Aug 16 10:47:16 2010
+++ src/tests/fs/vfs/t_vfsops.c Fri Nov 19 17:46:02 2010
@@ -1,4 +1,4 @@
-/* $NetBSD: t_vfsops.c,v 1.7 2010/08/16 10:47:16 pooka Exp $ */
+/* $NetBSD: t_vfsops.c,v 1.8 2010/11/19 17:46:02 pooka Exp $ */
/*-
* Copyright (c) 2010 The NetBSD Foundation, Inc.
@@ -134,10 +134,6 @@
void *fhp;
int fd;
- /* should repeat above, but ... */
- if (FSTYPE_TMPFS(tc))
- atf_tc_skip("file handles broken (PR kern/43605)");
-
RL(rump_sys_chdir(path));
RL(fd = rump_sys_open(FNAME, O_RDWR | O_CREAT, 0777));
RL(rump_sys_close(fd));
@@ -158,6 +154,8 @@
if (FSTYPE_MSDOS(tc) || FSTYPE_LFS(tc))
atf_tc_expect_fail("fhopen() for removed file succeeds "
"(PR kern/43745)");
+ if (FSTYPE_TMPFS(tc))
+ atf_tc_expect_fail("PR kern/43605");
ATF_REQUIRE_ERRNO(ESTALE, rump_sys_fhopen(fhp, fhsize, O_RDONLY) == -1);
atf_tc_expect_pass();
@@ -177,8 +175,7 @@
unsigned long seed;
int fd;
- if (FSTYPE_TMPFS(tc))
- atf_tc_skip("file handles broken (PR kern/43605)");
+ /* XXX: this test succeeds "accidentally" on tmpfs, PR kern/43605 */
srandom(seed = time(NULL));
printf("RNG seed %lu\n", seed);
