Module Name: src
Committed By: christos
Date: Fri Dec 3 01:29:55 UTC 2010
Modified Files:
src/tests/util/make: Makefile t_make.sh
Added Files:
src/tests/util/make: d_unmatchedvarparen.mk d_unmatchedvarparen.out
Log Message:
Add a new test for the latest variable expansion problem.
- Cannot test because make test prints:
.: Can't open /usr/share/atf/atf.header.subr
- The shell script common code needs to be fixed to follow regular shell
style.
- variables are underquoted
- uses `` instead of $()
- does not use local for local variables, prefixes with undescore
- needlessly uses braces for numeric and symbolic variables.
- uses a fifo to grab output, and does not clean it up properly on error
- should not exit with > 127 !!!
To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/tests/util/make/Makefile \
src/tests/util/make/t_make.sh
cvs rdiff -u -r0 -r1.1 src/tests/util/make/d_unmatchedvarparen.mk \
src/tests/util/make/d_unmatchedvarparen.out
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/tests/util/make/Makefile
diff -u src/tests/util/make/Makefile:1.2 src/tests/util/make/Makefile:1.3
--- src/tests/util/make/Makefile:1.2 Sat Jul 10 12:16:12 2010
+++ src/tests/util/make/Makefile Thu Dec 2 20:29:55 2010
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.2 2010/07/10 16:16:12 jmmv Exp $
+# $NetBSD: Makefile,v 1.3 2010/12/03 01:29:55 christos Exp $
NOMAN= # defined
@@ -37,6 +37,8 @@
FILES+= d_qequals.out
FILES+= d_ternary.mk
FILES+= d_ternary.out
+FILES+= d_unmatchedvarparen.mk
+FILES+= d_unmatchedvarparen.out
FILES+= d_varcmd.mk
FILES+= d_varcmd.out
Index: src/tests/util/make/t_make.sh
diff -u src/tests/util/make/t_make.sh:1.2 src/tests/util/make/t_make.sh:1.3
--- src/tests/util/make/t_make.sh:1.2 Sun Nov 7 12:51:23 2010
+++ src/tests/util/make/t_make.sh Thu Dec 2 20:29:55 2010
@@ -1,4 +1,4 @@
-# $NetBSD: t_make.sh,v 1.2 2010/11/07 17:51:23 jmmv Exp $
+# $NetBSD: t_make.sh,v 1.3 2010/12/03 01:29:55 christos Exp $
#
# Copyright (c) 2008, 2010 The NetBSD Foundation, Inc.
# All rights reserved.
@@ -66,6 +66,7 @@
test_case qequals "Checks operator ?="
test_case ternary "Checks ternary modifier"
test_case varcmd "Checks behavior of command line variable assignments"
+test_case unmatchedvarparen "Checks $ ( ) matches"
atf_init_test_cases()
{
@@ -84,4 +85,5 @@
atf_add_test_case qequals
atf_add_test_case ternary
atf_add_test_case varcmd
+ atf_add_test_case unmathedvarparen
}
Added files:
Index: src/tests/util/make/d_unmatchedvarparen.mk
diff -u /dev/null src/tests/util/make/d_unmatchedvarparen.mk:1.1
--- /dev/null Thu Dec 2 20:29:56 2010
+++ src/tests/util/make/d_unmatchedvarparen.mk Thu Dec 2 20:29:55 2010
@@ -0,0 +1,3 @@
+
+all:
+ @echo $(foo::=foo-text)
