Module Name: src Committed By: wiz Date: Tue Jan 4 10:26:56 UTC 2011
Modified Files: src/usr.sbin/traceroute: as.c Log Message: Fix possible NULL pointer dereference in #ifdef AS_DEBUG_FILE. Found by cppcheck. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/usr.sbin/traceroute/as.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Modified files: Index: src/usr.sbin/traceroute/as.c diff -u src/usr.sbin/traceroute/as.c:1.2 src/usr.sbin/traceroute/as.c:1.3 --- src/usr.sbin/traceroute/as.c:1.2 Mon Apr 28 20:24:17 2008 +++ src/usr.sbin/traceroute/as.c Tue Jan 4 10:26:56 2011 @@ -1,4 +1,4 @@ -/* $NetBSD: as.c,v 1.2 2008/04/28 20:24:17 martin Exp $ */ +/* $NetBSD: as.c,v 1.3 2011/01/04 10:26:56 wiz Exp $ */ /* * Copyright (c) 2001 The NetBSD Foundation, Inc. @@ -119,10 +119,12 @@ asn->as_f = f; #ifdef AS_DEBUG_FILE - asn->as_debug = fopen(AS_DEBUG_FILE, "w"); - if (asn->as_debug) { - (void)fprintf(asn->as_debug, ">> !!\n"); - (void)fflush(asn->as_debug); + if (asn) { + asn->as_debug = fopen(AS_DEBUG_FILE, "w"); + if (asn->as_debug) { + (void)fprintf(asn->as_debug, ">> !!\n"); + (void)fflush(asn->as_debug); + } } #endif /* AS_DEBUG_FILE */