Module Name:    src
Committed By:   dholland
Date:           Mon Apr 11 02:19:43 UTC 2011

Modified Files:
        src/sys/kern: vfs_lookup.c

Log Message:
description:
Don't assign inside an if-expression without an explicit comparison.


To generate a diff of this commit:
cvs rdiff -u -r1.168 -r1.169 src/sys/kern/vfs_lookup.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/kern/vfs_lookup.c
diff -u src/sys/kern/vfs_lookup.c:1.168 src/sys/kern/vfs_lookup.c:1.169
--- src/sys/kern/vfs_lookup.c:1.168	Mon Apr 11 02:19:27 2011
+++ src/sys/kern/vfs_lookup.c	Mon Apr 11 02:19:42 2011
@@ -1,4 +1,4 @@
-/*	$NetBSD: vfs_lookup.c,v 1.168 2011/04/11 02:19:27 dholland Exp $	*/
+/*	$NetBSD: vfs_lookup.c,v 1.169 2011/04/11 02:19:42 dholland Exp $	*/
 
 /*
  * Copyright (c) 1982, 1986, 1989, 1993
@@ -37,7 +37,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: vfs_lookup.c,v 1.168 2011/04/11 02:19:27 dholland Exp $");
+__KERNEL_RCSID(0, "$NetBSD: vfs_lookup.c,v 1.169 2011/04/11 02:19:42 dholland Exp $");
 
 #include "opt_magiclinks.h"
 
@@ -997,7 +997,8 @@
 	 * Check to see if the vnode has been mounted on;
 	 * if so find the root of the mounted file system.
 	 */
-	while (foundobj->v_type == VDIR && (mp = foundobj->v_mountedhere) &&
+	while (foundobj->v_type == VDIR &&
+	       (mp = foundobj->v_mountedhere) != NULL &&
 	       (cnp->cn_flags & NOCROSSMOUNT) == 0) {
 		error = vfs_busy(mp, NULL);
 		if (error != 0) {

Reply via email to