Module Name:    src
Committed By:   dholland
Date:           Mon Jul 18 02:35:11 UTC 2011

Modified Files:
        src/sys/ufs/ufs: ufs_vnops.c

Log Message:
ok, it is clear that at least vput(vp) needs to go before fstrans_done().
I hoping vput(dvp) doesn't, because if it does that will vastly complicate
future vfs locking cleanup.


To generate a diff of this commit:
cvs rdiff -u -r1.197 -r1.198 src/sys/ufs/ufs/ufs_vnops.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/ufs/ufs/ufs_vnops.c
diff -u src/sys/ufs/ufs/ufs_vnops.c:1.197 src/sys/ufs/ufs/ufs_vnops.c:1.198
--- src/sys/ufs/ufs/ufs_vnops.c:1.197	Mon Jul 18 01:52:55 2011
+++ src/sys/ufs/ufs/ufs_vnops.c	Mon Jul 18 02:35:11 2011
@@ -1,4 +1,4 @@
-/*	$NetBSD: ufs_vnops.c,v 1.197 2011/07/18 01:52:55 dholland Exp $	*/
+/*	$NetBSD: ufs_vnops.c,v 1.198 2011/07/18 02:35:11 dholland Exp $	*/
 
 /*-
  * Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -66,7 +66,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ufs_vnops.c,v 1.197 2011/07/18 01:52:55 dholland Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ufs_vnops.c,v 1.198 2011/07/18 02:35:11 dholland Exp $");
 
 #if defined(_KERNEL_OPT)
 #include "opt_ffs.h"
@@ -1763,9 +1763,9 @@
 #endif
  out:
 	VN_KNOTE(vp, NOTE_DELETE);
+	vput(vp);
 	fstrans_done(dvp->v_mount);
 	vput(dvp);
-	vput(vp);
 	return (error);
 }
 

Reply via email to