Module Name:    src
Committed By:   jruoho
Date:           Sun Sep 11 10:32:24 UTC 2011

Modified Files:
        src/distrib/sets/lists/tests: mi
        src/tests/lib/libc/stdlib: Makefile
Added Files:
        src/tests/lib/libc/stdlib: t_system.c

Log Message:
See that system(3) works.


To generate a diff of this commit:
cvs rdiff -u -r1.381 -r1.382 src/distrib/sets/lists/tests/mi
cvs rdiff -u -r1.17 -r1.18 src/tests/lib/libc/stdlib/Makefile
cvs rdiff -u -r0 -r1.1 src/tests/lib/libc/stdlib/t_system.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/distrib/sets/lists/tests/mi
diff -u src/distrib/sets/lists/tests/mi:1.381 src/distrib/sets/lists/tests/mi:1.382
--- src/distrib/sets/lists/tests/mi:1.381	Sun Sep 11 09:02:45 2011
+++ src/distrib/sets/lists/tests/mi	Sun Sep 11 10:32:23 2011
@@ -1,4 +1,4 @@
-# $NetBSD: mi,v 1.381 2011/09/11 09:02:45 jruoho Exp $
+# $NetBSD: mi,v 1.382 2011/09/11 10:32:23 jruoho Exp $
 #
 # Note: don't delete entries from here - mark them as "obsolete" instead.
 #
@@ -460,6 +460,7 @@
 ./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_strtod.debug		tests-lib-debug		debug,atf
 ./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_strtol.debug		tests-lib-debug		debug,atf
 ./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_strtox.debug		tests-obsolete		obsolete
+./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_system.debug		tests-lib-debug		debug,atf
 ./usr/libdata/debug/usr/tests/lib/libc/string				tests-lib-debug
 ./usr/libdata/debug/usr/tests/lib/libc/string/t_memchr.debug		tests-lib-debug		debug,atf
 ./usr/libdata/debug/usr/tests/lib/libc/string/t_memcpy.debug		tests-lib-debug		debug,atf
@@ -2050,6 +2051,7 @@
 ./usr/tests/lib/libc/stdlib/t_strtod		tests-lib-tests		atf
 ./usr/tests/lib/libc/stdlib/t_strtol		tests-lib-tests		atf
 ./usr/tests/lib/libc/stdlib/t_strtox		tests-obsolete		obsolete
+./usr/tests/lib/libc/stdlib/t_system		tests-lib-tests		atf
 ./usr/tests/lib/libc/string			tests-lib-tests
 ./usr/tests/lib/libc/string/Atffile		tests-lib-tests		atf
 ./usr/tests/lib/libc/string/t_memchr		tests-lib-tests		atf

Index: src/tests/lib/libc/stdlib/Makefile
diff -u src/tests/lib/libc/stdlib/Makefile:1.17 src/tests/lib/libc/stdlib/Makefile:1.18
--- src/tests/lib/libc/stdlib/Makefile:1.17	Fri Jul 15 14:00:41 2011
+++ src/tests/lib/libc/stdlib/Makefile	Sun Sep 11 10:32:23 2011
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.17 2011/07/15 14:00:41 jruoho Exp $
+# $NetBSD: Makefile,v 1.18 2011/09/11 10:32:23 jruoho Exp $
 
 .include <bsd.own.mk>
 
@@ -13,6 +13,7 @@
 TESTS_C+=	t_posix_memalign
 TESTS_C+=	t_strtod
 TESTS_C+=	t_strtol
+TESTS_C+=	t_system
 
 TESTS_SH+=	t_atexit
 TESTS_SH+=	t_getopt

Added files:

Index: src/tests/lib/libc/stdlib/t_system.c
diff -u /dev/null src/tests/lib/libc/stdlib/t_system.c:1.1
--- /dev/null	Sun Sep 11 10:32:24 2011
+++ src/tests/lib/libc/stdlib/t_system.c	Sun Sep 11 10:32:23 2011
@@ -0,0 +1,83 @@
+/* $NetBSD: t_system.c,v 1.1 2011/09/11 10:32:23 jruoho Exp $ */
+
+/*-
+ * Copyright (c) 2011 The NetBSD Foundation, Inc.
+ * All rights reserved.
+ *
+ * This code is derived from software contributed to The NetBSD Foundation
+ * by Jukka Ruohonen.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
+ * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
+ * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+#include <sys/cdefs.h>
+__RCSID("$NetBSD: t_system.c,v 1.1 2011/09/11 10:32:23 jruoho Exp $");
+
+#include <atf-c.h>
+#include <fcntl.h>
+#include <stdlib.h>
+#include <string.h>
+#include <unistd.h>
+
+static const char *path = "system";
+
+ATF_TC_WITH_CLEANUP(system_basic);
+ATF_TC_HEAD(system_basic, tc)
+{
+	atf_tc_set_md_var(tc, "descr", "A basic test of system(3)");
+}
+
+ATF_TC_BODY(system_basic, tc)
+{
+	char buf[23];
+	int fd, i = 2;
+
+	ATF_REQUIRE(system("/bin/echo -n > system") == 0);
+
+	while (i >= 0) {
+		ATF_REQUIRE(system("/bin/echo -n garbage >> system") == 0);
+		i--;
+	}
+
+	fd = open(path, O_RDONLY);
+	ATF_REQUIRE(fd >= 0);
+
+	(void)memset(buf, '\0', sizeof(buf));
+
+	ATF_REQUIRE(read(fd, buf, 21) == 21);
+	ATF_REQUIRE(strcmp(buf, "garbagegarbagegarbage") == 0);
+
+	ATF_REQUIRE(close(fd) == 0);
+	ATF_REQUIRE(unlink(path) == 0);
+}
+
+ATF_TC_CLEANUP(system_basic, tc)
+{
+	(void)unlink(path);
+}
+
+ATF_TP_ADD_TCS(tp)
+{
+
+	ATF_TP_ADD_TC(tp, system_basic);
+
+	return atf_no_error();
+}

Reply via email to