Module Name: src
Committed By: christos
Date: Sat Dec 24 23:42:30 UTC 2011
Modified Files:
src/usr.sbin/catman: catman.c
Log Message:
check also for overflow
To generate a diff of this commit:
cvs rdiff -u -r1.32 -r1.33 src/usr.sbin/catman/catman.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.sbin/catman/catman.c
diff -u src/usr.sbin/catman/catman.c:1.32 src/usr.sbin/catman/catman.c:1.33
--- src/usr.sbin/catman/catman.c:1.32 Sat Dec 24 18:38:43 2011
+++ src/usr.sbin/catman/catman.c Sat Dec 24 18:42:30 2011
@@ -1,4 +1,4 @@
-/* $NetBSD: catman.c,v 1.32 2011/12/24 23:38:43 christos Exp $ */
+/* $NetBSD: catman.c,v 1.33 2011/12/24 23:42:30 christos Exp $ */
/*
* Copyright (c) 1998 The NetBSD Foundation, Inc.
@@ -564,8 +564,8 @@ makecat(const char *manpage, const char
int len;
len = snprintf(sysbuf, sizeof(sysbuf), buildcmd, manpage);
- if (len < 0)
- err(1, "snprintf");
+ if (len < 0 || len > sizeof(sysbuf))
+ errx(1, "snprintf");
if (*crunchcmd != '\0') {
snprintf(crunchbuf, sizeof(crunchbuf), crunchcmd, catpage);
