Module Name: src
Committed By: dholland
Date: Sat Mar 3 23:16:47 UTC 2012
Modified Files:
src/usr.bin/make: str.c
Log Message:
Note in comment that Str_Match() does not detect or report invalid
patterns. This is not critical, since for the moment both possible
cases (unclosed [], and \ at the end of the string) are handled more
or less sanely.
To generate a diff of this commit:
cvs rdiff -u -r1.33 -r1.34 src/usr.bin/make/str.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.bin/make/str.c
diff -u src/usr.bin/make/str.c:1.33 src/usr.bin/make/str.c:1.34
--- src/usr.bin/make/str.c:1.33 Wed Feb 25 21:17:21 2009
+++ src/usr.bin/make/str.c Sat Mar 3 23:16:47 2012
@@ -1,4 +1,4 @@
-/* $NetBSD: str.c,v 1.33 2009/02/25 21:17:21 sno Exp $ */
+/* $NetBSD: str.c,v 1.34 2012/03/03 23:16:47 dholland Exp $ */
/*-
* Copyright (c) 1988, 1989, 1990, 1993
@@ -69,14 +69,14 @@
*/
#ifndef MAKE_NATIVE
-static char rcsid[] = "$NetBSD: str.c,v 1.33 2009/02/25 21:17:21 sno Exp $";
+static char rcsid[] = "$NetBSD: str.c,v 1.34 2012/03/03 23:16:47 dholland Exp $";
#else
#include <sys/cdefs.h>
#ifndef lint
#if 0
static char sccsid[] = "@(#)str.c 5.8 (Berkeley) 6/1/90";
#else
-__RCSID("$NetBSD: str.c,v 1.33 2009/02/25 21:17:21 sno Exp $");
+__RCSID("$NetBSD: str.c,v 1.34 2012/03/03 23:16:47 dholland Exp $");
#endif
#endif /* not lint */
#endif
@@ -319,6 +319,8 @@ Str_FindSubstring(const char *string, co
* matching operation permits the following special characters in the
* pattern: *?\[] (see the man page for details on what these mean).
*
+ * XXX this function does not detect or report malformed patterns.
+ *
* Side effects: None.
*/
int
