Module Name: src
Committed By: jruoho
Date: Wed Mar 28 10:33:58 UTC 2012
Modified Files:
src/distrib/sets/lists/tests: mi
src/tests/lib/libc/stdlib: Makefile
Added Files:
src/tests/lib/libc/stdlib: t_random.c
Log Message:
Add a small test that checks that random(3) does not always return zero when
the RNG is initialized with zero. Prompoted by the recent nasty bug in the
OpenBSD libc.
To generate a diff of this commit:
cvs rdiff -u -r1.458 -r1.459 src/distrib/sets/lists/tests/mi
cvs rdiff -u -r1.19 -r1.20 src/tests/lib/libc/stdlib/Makefile
cvs rdiff -u -r0 -r1.1 src/tests/lib/libc/stdlib/t_random.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/distrib/sets/lists/tests/mi
diff -u src/distrib/sets/lists/tests/mi:1.458 src/distrib/sets/lists/tests/mi:1.459
--- src/distrib/sets/lists/tests/mi:1.458 Tue Mar 27 08:16:33 2012
+++ src/distrib/sets/lists/tests/mi Wed Mar 28 10:33:57 2012
@@ -1,4 +1,4 @@
-# $NetBSD: mi,v 1.458 2012/03/27 08:16:33 jruoho Exp $
+# $NetBSD: mi,v 1.459 2012/03/28 10:33:57 jruoho Exp $
#
# Note: don't delete entries from here - mark them as "obsolete" instead.
#
@@ -495,6 +495,7 @@
./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_hsearch.debug tests-lib-debug debug,atf
./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_mi_vector_hash.debug tests-lib-debug debug,atf
./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_posix_memalign.debug tests-lib-debug debug,atf
+./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_random.debug tests-lib-debug debug,atf
./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_strtod.debug tests-lib-debug debug,atf
./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_strtol.debug tests-lib-debug debug,atf
./usr/libdata/debug/usr/tests/lib/libc/stdlib/t_strtox.debug tests-obsolete obsolete
@@ -2387,6 +2388,7 @@
./usr/tests/lib/libc/stdlib/t_hsearch tests-lib-tests atf
./usr/tests/lib/libc/stdlib/t_mi_vector_hash tests-lib-tests atf
./usr/tests/lib/libc/stdlib/t_posix_memalign tests-lib-tests atf
+./usr/tests/lib/libc/stdlib/t_random tests-lib-tests atf
./usr/tests/lib/libc/stdlib/t_strtod tests-lib-tests atf
./usr/tests/lib/libc/stdlib/t_strtol tests-lib-tests atf
./usr/tests/lib/libc/stdlib/t_strtox tests-obsolete obsolete
Index: src/tests/lib/libc/stdlib/Makefile
diff -u src/tests/lib/libc/stdlib/Makefile:1.19 src/tests/lib/libc/stdlib/Makefile:1.20
--- src/tests/lib/libc/stdlib/Makefile:1.19 Fri Feb 24 14:02:55 2012
+++ src/tests/lib/libc/stdlib/Makefile Wed Mar 28 10:33:57 2012
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.19 2012/02/24 14:02:55 joerg Exp $
+# $NetBSD: Makefile,v 1.20 2012/03/28 10:33:57 jruoho Exp $
.include <bsd.own.mk>
@@ -11,6 +11,7 @@ TESTS_C+= t_exit
TESTS_C+= t_hsearch
TESTS_C+= t_mi_vector_hash
TESTS_C+= t_posix_memalign
+TESTS_C+= t_random
TESTS_C+= t_strtod
TESTS_C+= t_strtol
TESTS_C+= t_system
Added files:
Index: src/tests/lib/libc/stdlib/t_random.c
diff -u /dev/null src/tests/lib/libc/stdlib/t_random.c:1.1
--- /dev/null Wed Mar 28 10:33:58 2012
+++ src/tests/lib/libc/stdlib/t_random.c Wed Mar 28 10:33:57 2012
@@ -0,0 +1,72 @@
+/* $NetBSD: t_random.c,v 1.1 2012/03/28 10:33:57 jruoho Exp $ */
+
+/*-
+ * Copyright (c) 2012 The NetBSD Foundation, Inc.
+ * All rights reserved.
+ *
+ * This code is derived from software contributed to The NetBSD Foundation
+ * by Jukka Ruohonen.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
+ * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
+ * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+#include <sys/cdefs.h>
+__RCSID("$NetBSD: t_random.c,v 1.1 2012/03/28 10:33:57 jruoho Exp $");
+
+#include <atf-c.h>
+#include <stdlib.h>
+
+/*
+ * TODO: Add some general RNG tests (cf. the famous "diehard" tests?).
+ */
+
+ATF_TC(random_zero);
+ATF_TC_HEAD(random_zero, tc)
+{
+ atf_tc_set_md_var(tc, "descr",
+ "Test that random(3) does not always return "
+ "zero when the seed is initialized to zero");
+}
+
+ATF_TC_BODY(random_zero, tc)
+{
+ const size_t n = 1000000;
+ size_t i, j;
+ long x;
+
+ srandom(0);
+
+ for (i = j = 0; i < n; i++) {
+
+ if ((x = random()) == 0)
+ j++;
+ }
+
+ ATF_REQUIRE(j != n);
+}
+
+ATF_TP_ADD_TCS(tp)
+{
+
+ ATF_TP_ADD_TC(tp, random_zero);
+
+ return atf_no_error();
+}
