Module Name: src
Committed By: martin
Date: Sun Apr 15 15:35:01 UTC 2012
Modified Files:
src/sys/kern: kern_exec.c
Log Message:
Fix leak in a posix_spawn error path, from Greg Oster.
To generate a diff of this commit:
cvs rdiff -u -r1.349 -r1.350 src/sys/kern/kern_exec.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/kern/kern_exec.c
diff -u src/sys/kern/kern_exec.c:1.349 src/sys/kern/kern_exec.c:1.350
--- src/sys/kern/kern_exec.c:1.349 Mon Apr 9 19:42:06 2012
+++ src/sys/kern/kern_exec.c Sun Apr 15 15:35:00 2012
@@ -1,4 +1,4 @@
-/* $NetBSD: kern_exec.c,v 1.349 2012/04/09 19:42:06 martin Exp $ */
+/* $NetBSD: kern_exec.c,v 1.350 2012/04/15 15:35:00 martin Exp $ */
/*-
* Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -59,7 +59,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: kern_exec.c,v 1.349 2012/04/09 19:42:06 martin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: kern_exec.c,v 1.350 2012/04/15 15:35:00 martin Exp $");
#include "opt_exec.h"
#include "opt_ktrace.h"
@@ -1978,8 +1978,16 @@ spawn_return(void *arg)
return;
report_error:
- if (have_reflock)
+ if (have_reflock) {
+ /*
+ * We have not passed through execve_runproc(),
+ * which would have released the p_reflock and also
+ * taken ownership of the sed_exec part of spawn_data,
+ * so release/free both here.
+ */
rw_exit(&l->l_proc->p_reflock);
+ execve_free_data(&spawn_data->sed_exec);
+ }
if (parent_is_waiting) {
/* pass error to parent */
