Module Name:    src
Committed By:   martin
Date:           Tue Jun 19 14:19:46 UTC 2012

Modified Files:
        src/sys/dev/iscsi: iscsi_send.c

Log Message:
assemble_login_parameters() has a strange error reporting convention:
errors are positive numbers, so <= 0 is good, not >= ...
This makes CHAP authenticated iscsi logins work.


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/dev/iscsi/iscsi_send.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/dev/iscsi/iscsi_send.c
diff -u src/sys/dev/iscsi/iscsi_send.c:1.3 src/sys/dev/iscsi/iscsi_send.c:1.4
--- src/sys/dev/iscsi/iscsi_send.c:1.3	Sat Jun  9 06:19:58 2012
+++ src/sys/dev/iscsi/iscsi_send.c	Tue Jun 19 14:19:46 2012
@@ -1,4 +1,4 @@
-/*	$NetBSD: iscsi_send.c,v 1.3 2012/06/09 06:19:58 mlelstv Exp $	*/
+/*	$NetBSD: iscsi_send.c,v 1.4 2012/06/19 14:19:46 martin Exp $	*/
 
 /*-
  * Copyright (c) 2004,2005,2006,2011 The NetBSD Foundation, Inc.
@@ -1113,7 +1113,7 @@ send_login(connection_t *conn)
 		return conn->terminating;
 	}
 
-	if ((rc = assemble_login_parameters(conn, ccb, pdu)) >= 0) {
+	if ((rc = assemble_login_parameters(conn, ccb, pdu)) <= 0) {
 		init_login_pdu(conn, pdu, !rc);
 		setup_tx_uio(pdu, pdu->temp_data_len, pdu->temp_data, FALSE);
 		send_pdu(ccb, pdu, CCBDISP_WAIT, PDUDISP_FREE);

Reply via email to