Module Name:    xsrc
Committed By:   apb
Date:           Fri Nov  2 07:47:19 UTC 2012

Modified Files:
        xsrc/external/mit/xf86-video-xgi/dist/src: vb_i2c.c xgi_accel.c

Log Message:
Add returns in non-void functions.  Found using clang -Wreturn-type.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 xsrc/external/mit/xf86-video-xgi/dist/src/vb_i2c.c
cvs rdiff -u -r1.3 -r1.4 \
    xsrc/external/mit/xf86-video-xgi/dist/src/xgi_accel.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: xsrc/external/mit/xf86-video-xgi/dist/src/vb_i2c.c
diff -u xsrc/external/mit/xf86-video-xgi/dist/src/vb_i2c.c:1.2 xsrc/external/mit/xf86-video-xgi/dist/src/vb_i2c.c:1.3
--- xsrc/external/mit/xf86-video-xgi/dist/src/vb_i2c.c:1.2	Thu Jul 19 19:18:20 2012
+++ xsrc/external/mit/xf86-video-xgi/dist/src/vb_i2c.c	Fri Nov  2 07:47:19 2012
@@ -1631,8 +1631,10 @@ BOOLEAN bReadClockLine(PXGI_HW_DEVICE_IN
 		return(bReadClockLineDVI(pHWDE));
 	else if(pHWDE->crtno == 2)
 		return(bReadClockLineFCNT(pHWDE));
-	else
+	else {
 		ErrorF("Error(XGI) : Unkonwn output device! \n");
+		return FALSE;
+	}
 }
 
 BOOLEAN bReadDataLine(PXGI_HW_DEVICE_INFO pHWDE)
@@ -1643,8 +1645,10 @@ BOOLEAN bReadDataLine(PXGI_HW_DEVICE_INF
 		return(bReadDataLineDVI(pHWDE));
 	else if(pHWDE->crtno == 2)
 		return(bReadDataLineFCNT(pHWDE));
-	else
+	else {
 		ErrorF("Error(XGI) : Unkonwn output device! \n");
+		return FALSE;
+	}
 }
 
 BOOLEAN bEDIDCheckSum(PUCHAR  pjEDIDBuf,ULONG   ulBufSize)
@@ -1891,4 +1895,4 @@ BOOLEAN bGetEDID(
 
    PDEBUGI2C(ErrorF("bGetEDID()-return(%d)\n", status == NO_ERROR ? 1:0));
     return (status == NO_ERROR);
-}
\ No newline at end of file
+}

Index: xsrc/external/mit/xf86-video-xgi/dist/src/xgi_accel.c
diff -u xsrc/external/mit/xf86-video-xgi/dist/src/xgi_accel.c:1.3 xsrc/external/mit/xf86-video-xgi/dist/src/xgi_accel.c:1.4
--- xsrc/external/mit/xf86-video-xgi/dist/src/xgi_accel.c:1.3	Fri Nov  2 07:44:10 2012
+++ xsrc/external/mit/xf86-video-xgi/dist/src/xgi_accel.c	Fri Nov  2 07:47:19 2012
@@ -959,6 +959,7 @@ Volari_AccelInit(ScreenPtr pScreen)
             return TRUE;
 	}
 #endif /* EXA */
+	return FALSE;
 }
 
 void

Reply via email to