Module Name: src
Committed By: gdt
Date: Thu Mar 14 19:13:17 UTC 2013
Modified Files:
src/sys/kern: uipc_socket.c
Log Message:
Add comment questioning lock asymmetry.
To generate a diff of this commit:
cvs rdiff -u -r1.213 -r1.214 src/sys/kern/uipc_socket.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/kern/uipc_socket.c
diff -u src/sys/kern/uipc_socket.c:1.213 src/sys/kern/uipc_socket.c:1.214
--- src/sys/kern/uipc_socket.c:1.213 Thu Feb 14 21:57:58 2013
+++ src/sys/kern/uipc_socket.c Thu Mar 14 19:13:17 2013
@@ -1,4 +1,4 @@
-/* $NetBSD: uipc_socket.c,v 1.213 2013/02/14 21:57:58 christos Exp $ */
+/* $NetBSD: uipc_socket.c,v 1.214 2013/03/14 19:13:17 gdt Exp $ */
/*-
* Copyright (c) 2002, 2007, 2008, 2009 The NetBSD Foundation, Inc.
@@ -63,7 +63,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uipc_socket.c,v 1.213 2013/02/14 21:57:58 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uipc_socket.c,v 1.214 2013/03/14 19:13:17 gdt Exp $");
#include "opt_compat_netbsd.h"
#include "opt_sock_counters.h"
@@ -538,6 +538,7 @@ socreate(int dom, struct socket **aso, i
lock = lockso->so_lock;
so->so_lock = lock;
mutex_obj_hold(lock);
+ /* XXX Why is this not solock, to match sounlock? */
mutex_enter(lock);
} else {
/* Lock assigned and taken during PRU_ATTACH. */
