Module Name:    src
Committed By:   maxv
Date:           Sat Mar  1 16:59:42 UTC 2014

Modified Files:
        src/sys/dev/acpi: tpm_acpi.c

Log Message:
Some {} are missing. The behavior is thus wrong: the code always jumps to
out1.

Spotted by my code scanner.

ok christos@


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/dev/acpi/tpm_acpi.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/dev/acpi/tpm_acpi.c
diff -u src/sys/dev/acpi/tpm_acpi.c:1.3 src/sys/dev/acpi/tpm_acpi.c:1.4
--- src/sys/dev/acpi/tpm_acpi.c:1.3	Sun Jan 22 20:25:25 2012
+++ src/sys/dev/acpi/tpm_acpi.c	Sat Mar  1 16:59:41 2014
@@ -1,4 +1,4 @@
-/* $NetBSD: tpm_acpi.c,v 1.3 2012/01/22 20:25:25 christos Exp $ */
+/* $NetBSD: tpm_acpi.c,v 1.4 2014/03/01 16:59:41 maxv Exp $ */
 
 /*-
  * Copyright (c) 2012 The NetBSD Foundation, Inc.
@@ -52,7 +52,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: tpm_acpi.c,v 1.3 2012/01/22 20:25:25 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: tpm_acpi.c,v 1.4 2014/03/01 16:59:41 maxv Exp $");
 
 #include <sys/param.h>
 #include <sys/device.h>
@@ -185,9 +185,10 @@ tpm_acpi_attach(device_t parent, device_
 	else
 		inum = irq->ar_irq;
 
-	if ((rv = (*sc->sc_init)(sc, inum, device_xname(sc->sc_dev))) != 0)
+	if ((rv = (*sc->sc_init)(sc, inum, device_xname(sc->sc_dev))) != 0) {
 		aprint_error_dev(sc->sc_dev, "cannot init device %d\n", rv);
 		goto out1;
+	}
 
 	if (inum != -1 &&
 	    (sc->sc_ih = isa_intr_establish(aa->aa_ic, irq->ar_irq,

Reply via email to