Module Name: src
Committed By: bouyer
Date: Mon Apr 21 10:00:11 UTC 2014
Modified Files:
src/sys/kern [netbsd-6]: kern_exec.c
Log Message:
Pull up following revision(s) (requested by maxv in ticket #1048):
sys/kern/kern_exec.c: revision 1.403
'error' is not set on failure. This is a true bug: everything is freed
and unlocked while zero is returned. Since there's no error, execve_runproc()
will get called and will try to use those freed things.
To generate a diff of this commit:
cvs rdiff -u -r1.339.2.8 -r1.339.2.9 src/sys/kern/kern_exec.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/kern/kern_exec.c
diff -u src/sys/kern/kern_exec.c:1.339.2.8 src/sys/kern/kern_exec.c:1.339.2.9
--- src/sys/kern/kern_exec.c:1.339.2.8 Tue Mar 18 08:17:56 2014
+++ src/sys/kern/kern_exec.c Mon Apr 21 10:00:10 2014
@@ -1,4 +1,4 @@
-/* $NetBSD: kern_exec.c,v 1.339.2.8 2014/03/18 08:17:56 msaitoh Exp $ */
+/* $NetBSD: kern_exec.c,v 1.339.2.9 2014/04/21 10:00:10 bouyer Exp $ */
/*-
* Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -59,7 +59,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: kern_exec.c,v 1.339.2.8 2014/03/18 08:17:56 msaitoh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: kern_exec.c,v 1.339.2.9 2014/04/21 10:00:10 bouyer Exp $");
#include "opt_exec.h"
#include "opt_ktrace.h"
@@ -824,6 +824,7 @@ execve_loadvm(struct lwp *l, const char
if (len > data->ed_pack.ep_ssize) {
/* in effect, compare to initial limit */
DPRINTF(("%s: stack limit exceeded %zu\n", __func__, len));
+ error = ENOMEM;
goto bad;
}
/* adjust "active stack depth" for process VSZ */
