Module Name:    src
Committed By:   riastradh
Date:           Mon May 19 05:24:29 UTC 2014

Modified Files:
        src/sys/uvm: uvm_pglist.c

Log Message:
Don't leak memory on failure in uvm_pglistalloc_contig.

Free pages like uvm_pglistalloc_simple does.

Discovered by code inspection.


To generate a diff of this commit:
cvs rdiff -u -r1.63 -r1.64 src/sys/uvm/uvm_pglist.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/uvm/uvm_pglist.c
diff -u src/sys/uvm/uvm_pglist.c:1.63 src/sys/uvm/uvm_pglist.c:1.64
--- src/sys/uvm/uvm_pglist.c:1.63	Sun Sep 15 15:54:23 2013
+++ src/sys/uvm/uvm_pglist.c	Mon May 19 05:24:29 2014
@@ -1,4 +1,4 @@
-/*	$NetBSD: uvm_pglist.c,v 1.63 2013/09/15 15:54:23 martin Exp $	*/
+/*	$NetBSD: uvm_pglist.c,v 1.64 2014/05/19 05:24:29 riastradh Exp $	*/
 
 /*-
  * Copyright (c) 1997 The NetBSD Foundation, Inc.
@@ -35,7 +35,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uvm_pglist.c,v 1.63 2013/09/15 15:54:23 martin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uvm_pglist.c,v 1.64 2014/05/19 05:24:29 riastradh Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -354,6 +354,8 @@ out:
 
 	uvm_kick_pdaemon();
 	mutex_spin_exit(&uvm_fpageqlock);
+	if (error)
+		uvm_pglistfree(rlist);
 	return (error);
 }
 

Reply via email to