Module Name: src
Committed By: dholland
Date: Sun Jul 27 04:23:44 UTC 2014
Modified Files:
src/sbin/veriexecctl: veriexecctl.c
Log Message:
Fix snprintf usage and, while here, don't trundle off the end of an
array. Part of PR 47976 from Henning Petersen.
To generate a diff of this commit:
cvs rdiff -u -r1.36 -r1.37 src/sbin/veriexecctl/veriexecctl.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sbin/veriexecctl/veriexecctl.c
diff -u src/sbin/veriexecctl/veriexecctl.c:1.36 src/sbin/veriexecctl/veriexecctl.c:1.37
--- src/sbin/veriexecctl/veriexecctl.c:1.36 Sun Feb 9 13:40:59 2014
+++ src/sbin/veriexecctl/veriexecctl.c Sun Jul 27 04:23:44 2014
@@ -1,4 +1,4 @@
-/* $NetBSD: veriexecctl.c,v 1.36 2014/02/09 13:40:59 maxv Exp $ */
+/* $NetBSD: veriexecctl.c,v 1.37 2014/07/27 04:23:44 dholland Exp $ */
/*-
* Copyright 2005 Elad Efrat <[email protected]>
@@ -181,11 +181,11 @@ print_entry(prop_dictionary_t entry)
/* Get fingerprint in ASCII. */
len = prop_data_size(prop_dictionary_get(entry, "fp"));
- len *= 2;
- fp = calloc(1, len + 1);
+ fp = calloc(1, len*2 + 1);
v = dict_getd(entry, "fp");
- for (i = 0; i < len; i++)
- snprintf(fp, len + 1, "%s%02x", fp, v[i] & 0xff);
+ for (i = 0; i < len; i++) {
+ snprintf(&fp[i*2], 3, "%02x", v[i] & 0xff);
+ }
/* Get flags. */
memset(flags, 0, sizeof(flags));
