Module Name: src
Committed By: christos
Date: Fri Nov 7 12:57:42 UTC 2014
Modified Files:
src/sys/net: if.c
Log Message:
PR/49373: Ryota Ozaki: Running if_clone_create and if_clone_destroy in
parallel causes panic
XXX: Pullup 7.
To generate a diff of this commit:
cvs rdiff -u -r1.291 -r1.292 src/sys/net/if.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/net/if.c
diff -u src/sys/net/if.c:1.291 src/sys/net/if.c:1.292
--- src/sys/net/if.c:1.291 Tue Sep 9 16:16:12 2014
+++ src/sys/net/if.c Fri Nov 7 07:57:42 2014
@@ -1,4 +1,4 @@
-/* $NetBSD: if.c,v 1.291 2014/09/09 20:16:12 rmind Exp $ */
+/* $NetBSD: if.c,v 1.292 2014/11/07 12:57:42 christos Exp $ */
/*-
* Copyright (c) 1999, 2000, 2001, 2008 The NetBSD Foundation, Inc.
@@ -90,7 +90,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if.c,v 1.291 2014/09/09 20:16:12 rmind Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if.c,v 1.292 2014/11/07 12:57:42 christos Exp $");
#include "opt_inet.h"
@@ -164,6 +164,7 @@ static u_int if_index = 1;
static size_t if_indexlim = 0;
static uint64_t index_gen;
static kmutex_t index_gen_mtx;
+static kmutex_t if_clone_mtx;
static struct ifaddr ** ifnet_addrs = NULL;
@@ -252,6 +253,7 @@ void
ifinit1(void)
{
mutex_init(&index_gen_mtx, MUTEX_DEFAULT, IPL_NONE);
+ mutex_init(&if_clone_mtx, MUTEX_DEFAULT, IPL_NONE);
TAILQ_INIT(&ifnet_list);
if_indexlim = 8;
@@ -1850,6 +1852,7 @@ doifioctl(struct socket *so, u_long cmd,
struct ifreq ifrb;
struct oifreq *oifr = NULL;
#endif
+ int r;
switch (cmd) {
#ifdef COMPAT_OIFREQ
@@ -1891,9 +1894,12 @@ doifioctl(struct socket *so, u_long cmd,
if (error != 0)
return error;
}
- return (cmd == SIOCIFCREATE) ?
+ mutex_enter(&if_clone_mtx);
+ r = (cmd == SIOCIFCREATE) ?
if_clone_create(ifr->ifr_name) :
if_clone_destroy(ifr->ifr_name);
+ mutex_exit(&if_clone_mtx);
+ return r;
case SIOCIFGCLONERS:
return if_clone_list((struct if_clonereq *)data);
