Module Name: src
Committed By: joerg
Date: Sun Jan 11 22:59:57 UTC 2015
Modified Files:
src/sys/dev/marvell: if_gfe.c
Log Message:
sizeof doesn't evaluate the expression, so increment of rxd doesn't
happen. Move it out.
To generate a diff of this commit:
cvs rdiff -u -r1.43 -r1.44 src/sys/dev/marvell/if_gfe.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/marvell/if_gfe.c
diff -u src/sys/dev/marvell/if_gfe.c:1.43 src/sys/dev/marvell/if_gfe.c:1.44
--- src/sys/dev/marvell/if_gfe.c:1.43 Sun Sep 21 17:00:35 2014
+++ src/sys/dev/marvell/if_gfe.c Sun Jan 11 22:59:57 2015
@@ -1,4 +1,4 @@
-/* $NetBSD: if_gfe.c,v 1.43 2014/09/21 17:00:35 christos Exp $ */
+/* $NetBSD: if_gfe.c,v 1.44 2015/01/11 22:59:57 joerg Exp $ */
/*
* Copyright (c) 2002 Allegro Networks, Inc., Wasabi Systems, Inc.
@@ -42,7 +42,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_gfe.c,v 1.43 2014/09/21 17:00:35 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_gfe.c,v 1.44 2015/01/11 22:59:57 joerg Exp $");
#include "opt_inet.h"
@@ -816,7 +816,7 @@ gfe_rx_rxqinit(struct gfe_softc *sc, enu
ds = rxq->rxq_buf_mem.gdm_map->dm_segs;
nxtaddr = rxq->rxq_desc_busaddr + sizeof(*rxd);
for (idx = 0, rxd = rxq->rxq_descs; idx < GE_RXDESC_MAX;
- idx++, nxtaddr += sizeof(*(++rxd))) {
+ idx++, rxd++, nxtaddr += sizeof(*rxd)) {
rxd->ed_lencnt = htogt32(GE_RXBUF_SIZE << 16);
rxd->ed_cmdsts = htogt32(RX_CMD_F|RX_CMD_L|RX_CMD_O|RX_CMD_EI);
rxd->ed_bufptr = htogt32(ds->ds_addr + boff);