Module Name: src
Committed By: christos
Date: Wed Mar 11 16:00:55 UTC 2015
Modified Files:
src/sys/dev: lockstat.c
Log Message:
add coverity annotations (variable is volatile so it might have side effects)
To generate a diff of this commit:
cvs rdiff -u -r1.21 -r1.22 src/sys/dev/lockstat.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/lockstat.c
diff -u src/sys/dev/lockstat.c:1.21 src/sys/dev/lockstat.c:1.22
--- src/sys/dev/lockstat.c:1.21 Sun Mar 8 21:41:41 2015
+++ src/sys/dev/lockstat.c Wed Mar 11 12:00:54 2015
@@ -1,4 +1,4 @@
-/* $NetBSD: lockstat.c,v 1.21 2015/03/09 01:41:41 christos Exp $ */
+/* $NetBSD: lockstat.c,v 1.22 2015/03/11 16:00:54 christos Exp $ */
/*-
* Copyright (c) 2006, 2007 The NetBSD Foundation, Inc.
@@ -40,7 +40,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: lockstat.c,v 1.21 2015/03/09 01:41:41 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: lockstat.c,v 1.22 2015/03/11 16:00:54 christos Exp $");
#include <sys/types.h>
#include <sys/param.h>
@@ -166,6 +166,7 @@ lockstat_init_tables(lsenable_t *le)
lscpu_t *lc;
lsbuf_t *lb;
+ /* coverity[assert_side_effect] */
KASSERT(!lockstat_dev_enabled);
for (CPU_INFO_FOREACH(cii, ci)) {
@@ -211,6 +212,7 @@ void
lockstat_start(lsenable_t *le)
{
+ /* coverity[assert_side_effect] */
KASSERT(!lockstat_dev_enabled);
lockstat_init_tables(le);
@@ -249,6 +251,7 @@ lockstat_stop(lsdisable_t *ld)
int error;
lwp_t *l;
+ /* coverity[assert_side_effect] */
KASSERT(lockstat_dev_enabled);
/*
@@ -315,6 +318,7 @@ lockstat_alloc(lsenable_t *le)
lsbuf_t *lb;
size_t sz;
+ /* coverity[assert_side_effect] */
KASSERT(!lockstat_dev_enabled);
lockstat_free();
@@ -324,6 +328,7 @@ lockstat_alloc(lsenable_t *le)
if (lb == NULL)
return (ENOMEM);
+ /* coverity[assert_side_effect] */
KASSERT(!lockstat_dev_enabled);
KASSERT(lockstat_baseb == NULL);
lockstat_sizeb = sz;
@@ -339,6 +344,7 @@ void
lockstat_free(void)
{
+ /* coverity[assert_side_effect] */
KASSERT(!lockstat_dev_enabled);
if (lockstat_baseb != NULL) {
