Module Name:    src
Committed By:   riastradh
Date:           Tue Mar 31 11:43:05 UTC 2015

Modified Files:
        src/sys/ufs/ufs: ufs_readwrite.c

Log Message:
Amplify that even if we fixed it now the tentacles are still stuck.


To generate a diff of this commit:
cvs rdiff -u -r1.117 -r1.118 src/sys/ufs/ufs/ufs_readwrite.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/ufs/ufs/ufs_readwrite.c
diff -u src/sys/ufs/ufs/ufs_readwrite.c:1.117 src/sys/ufs/ufs/ufs_readwrite.c:1.118
--- src/sys/ufs/ufs/ufs_readwrite.c:1.117	Tue Mar 31 00:22:50 2015
+++ src/sys/ufs/ufs/ufs_readwrite.c	Tue Mar 31 11:43:05 2015
@@ -1,4 +1,4 @@
-/*	$NetBSD: ufs_readwrite.c,v 1.117 2015/03/31 00:22:50 riastradh Exp $	*/
+/*	$NetBSD: ufs_readwrite.c,v 1.118 2015/03/31 11:43:05 riastradh Exp $	*/
 
 /*-
  * Copyright (c) 1993
@@ -32,7 +32,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(1, "$NetBSD: ufs_readwrite.c,v 1.117 2015/03/31 00:22:50 riastradh Exp $");
+__KERNEL_RCSID(1, "$NetBSD: ufs_readwrite.c,v 1.118 2015/03/31 11:43:05 riastradh Exp $");
 
 #ifdef LFS_READWRITE
 #define	FS			struct lfs
@@ -349,6 +349,11 @@ WRITE(void *v)
 	 * genfs_getpages/putpages to cope with the possibility that
 	 * the transaction may or may not be locked on entry to the
 	 * page cache.
+	 *
+	 * And even if we added that notion to WAPBL, it wouldn't help
+	 * us get rid of the tentacles in genfs_getpages/putpages
+	 * because we'd have to interoperate with old implementations
+	 * that assume they can replay the log without fsck.
 	 */
 	error = UFS_WAPBL_BEGIN(vp->v_mount);
 	if (error) {

Reply via email to