Module Name:    src
Committed By:   msaitoh
Date:           Fri Apr  3 08:20:55 UTC 2015

Modified Files:
        src/sys/net: if.h

Log Message:
 Use 1000ULL to prevent integer overflow (for IF_Gbps(10)). Same as OpenBSD.


To generate a diff of this commit:
cvs rdiff -u -r1.185 -r1.186 src/sys/net/if.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/net/if.h
diff -u src/sys/net/if.h:1.185 src/sys/net/if.h:1.186
--- src/sys/net/if.h:1.185	Fri Jan 16 10:37:51 2015
+++ src/sys/net/if.h	Fri Apr  3 08:20:55 2015
@@ -1,4 +1,4 @@
-/*	$NetBSD: if.h,v 1.185 2015/01/16 10:37:51 ozaki-r Exp $	*/
+/*	$NetBSD: if.h,v 1.186 2015/04/03 08:20:55 msaitoh Exp $	*/
 
 /*-
  * Copyright (c) 1999, 2000, 2001 The NetBSD Foundation, Inc.
@@ -396,11 +396,10 @@ typedef struct ifnet {
 
 /*
  * Some convenience macros used for setting ifi_baudrate.
- * XXX 1000 vs. 1024? [email protected]
  */
-#define	IF_Kbps(x)	((x) * 1000)		/* kilobits/sec. */
-#define	IF_Mbps(x)	(IF_Kbps((x) * 1000))	/* megabits/sec. */
-#define	IF_Gbps(x)	(IF_Mbps((x) * 1000))	/* gigabits/sec. */
+#define	IF_Kbps(x)	((x) * 1000ULL)			/* kilobits/sec. */
+#define	IF_Mbps(x)	(IF_Kbps((x) * 1000ULL))	/* megabits/sec. */
+#define	IF_Gbps(x)	(IF_Mbps((x) * 1000ULL))	/* gigabits/sec. */
 
 /* Capabilities that interfaces can advertise. */
 					/* 0x01 .. 0x40 were previously used */

Reply via email to