Module Name:    src
Committed By:   pooka
Date:           Wed Apr 22 19:48:01 UTC 2015

Modified Files:
        src/sys/arch/i386/include: types.h

Log Message:
Revise rhetoric for why __HAVE_ATOMIC64_OPS is defined with _KERNEL even
though we don't know for sure that the target i386 CPU will support them.


To generate a diff of this commit:
cvs rdiff -u -r1.79 -r1.80 src/sys/arch/i386/include/types.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/arch/i386/include/types.h
diff -u src/sys/arch/i386/include/types.h:1.79 src/sys/arch/i386/include/types.h:1.80
--- src/sys/arch/i386/include/types.h:1.79	Thu Apr 24 19:23:00 2014
+++ src/sys/arch/i386/include/types.h	Wed Apr 22 19:48:01 2015
@@ -1,4 +1,4 @@
-/*	$NetBSD: types.h,v 1.79 2014/04/24 19:23:00 christos Exp $	*/
+/*	$NetBSD: types.h,v 1.80 2015/04/22 19:48:01 pooka Exp $	*/
 
 /*-
  * Copyright (c) 1990 The Regents of the University of California.
@@ -109,12 +109,13 @@ typedef	volatile unsigned char		__cpu_si
 #define	__HAVE_SYSCALL_INTERN
 #define	__HAVE_MINIMAL_EMUL
 #define	__HAVE_OLD_DISKLABEL
-#if defined(_KERNEL) && !defined(_RUMPKERNEL) && !defined(_RUMP_NATIVE_ABI)
+#if defined(_KERNEL)
 /*
  * Processors < i586 do not have cmpxchg8b, and we compile for i486
- * by default in userland. The kernel tsc driver uses them though,
- * and handles < i586 * by patching. We don't want to expose them in
- * userland, that is why we exclude rump.
+ * by default. The kernel tsc driver uses them though, and handles < i586
+ * by patching.  E.g. rump kernels and crash(8) and a selection of
+ * other run-in-userspace code defines _KERNEL, but is careful not to
+ * build anything using 64bit atomic ops by default.
  */
 #define __HAVE_ATOMIC64_OPS
 #endif

Reply via email to