Module Name:    src
Committed By:   christos
Date:           Fri Aug 21 06:50:56 UTC 2015

Modified Files:
        src/sys/kern: kern_ksyms.c

Log Message:
If we don't have a pseudo-device, we don't need the attach function.


To generate a diff of this commit:
cvs rdiff -u -r1.77 -r1.78 src/sys/kern/kern_ksyms.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/kern/kern_ksyms.c
diff -u src/sys/kern/kern_ksyms.c:1.77 src/sys/kern/kern_ksyms.c:1.78
--- src/sys/kern/kern_ksyms.c:1.77	Thu Aug 20 05:45:45 2015
+++ src/sys/kern/kern_ksyms.c	Fri Aug 21 02:50:56 2015
@@ -1,4 +1,4 @@
-/*	$NetBSD: kern_ksyms.c,v 1.77 2015/08/20 09:45:45 christos Exp $	*/
+/*	$NetBSD: kern_ksyms.c,v 1.78 2015/08/21 06:50:56 christos Exp $	*/
 
 /*-
  * Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -71,7 +71,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: kern_ksyms.c,v 1.77 2015/08/20 09:45:45 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: kern_ksyms.c,v 1.78 2015/08/21 06:50:56 christos Exp $");
 
 #if defined(_KERNEL) && defined(_KERNEL_OPT)
 #include "opt_ddb.h"
@@ -209,11 +209,19 @@ findsym(const char *name, struct ksyms_s
 /*
  * The "attach" is in reality done in ksyms_init().
  */
+#if NKSYMS >=  1
+/*
+ * ksyms can be loaded even if the kernel has a missing "pseudo-device ksyms"
+ * statement because ddb and modules require it. Fixing it properly requires
+ * fixing config to warn about required, but missing preudo-devices. For now,
+ * if we don't have the pseudo-device we don't need the attach function; this
+ * is fine, as it does nothing.
+ */
 void
 ksymsattach(int arg)
 {
-
 }
+#endif
 
 void
 ksyms_init(void)

Reply via email to