Module Name:    src
Committed By:   joerg
Date:           Fri Aug 28 13:04:29 UTC 2015

Modified Files:
        src/sys/dev: midictl.c

Log Message:
Don't left-shift negative numbers by making them unsigned.


To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/sys/dev/midictl.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/dev/midictl.c
diff -u src/sys/dev/midictl.c:1.7 src/sys/dev/midictl.c:1.8
--- src/sys/dev/midictl.c:1.7	Wed Nov 23 23:07:31 2011
+++ src/sys/dev/midictl.c	Fri Aug 28 13:04:29 2015
@@ -1,4 +1,4 @@
-/* $NetBSD: midictl.c,v 1.7 2011/11/23 23:07:31 jmcneill Exp $ */
+/* $NetBSD: midictl.c,v 1.8 2015/08/28 13:04:29 joerg Exp $ */
 
 /*-
  * Copyright (c) 2006, 2008 The NetBSD Foundation, Inc.
@@ -29,7 +29,7 @@
  * POSSIBILITY OF SUCH DAMAGE.
  */
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: midictl.c,v 1.7 2011/11/23 23:07:31 jmcneill Exp $");
+__KERNEL_RCSID(0, "$NetBSD: midictl.c,v 1.8 2015/08/28 13:04:29 joerg Exp $");
 
 /*
  * See midictl.h for an overview of the purpose and use of this module.
@@ -260,7 +260,7 @@ midictl_change(midictl *mc, uint_fast8_t
 		mc->nrpn &= ~PN_SET;
 		return;
 	case MIDI_CTRL_RPN_MSB:
-		mc-> rpn &= ~0x7f<<7;
+		mc-> rpn &= ~0x7fU<<7;
 		mc-> rpn |=  PN_SET | (0x7f & ctlval[1])<<7;
 		mc->nrpn &= ~PN_SET;
 		return;
@@ -270,7 +270,7 @@ midictl_change(midictl *mc, uint_fast8_t
 		mc-> rpn &= ~PN_SET;
 		return;
 	case MIDI_CTRL_NRPN_MSB:
-		mc->nrpn &= ~0x7f<<7;
+		mc->nrpn &= ~0x7fU<<7;
 		mc->nrpn |=  PN_SET | (0x7f & ctlval[1])<<7;
 		mc-> rpn &= ~PN_SET;
 		return;

Reply via email to