Module Name: src
Committed By: skrll
Date: Wed Dec 14 15:11:29 UTC 2016
Modified Files:
src/sys/dev/usb: ucom.c
Log Message:
Don't hold softc lock when calling ucom_read
PR/51714: uftdi (on xhci): mutex_vector_enter: locking against myself
To generate a diff of this commit:
cvs rdiff -u -r1.117 -r1.118 src/sys/dev/usb/ucom.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/usb/ucom.c
diff -u src/sys/dev/usb/ucom.c:1.117 src/sys/dev/usb/ucom.c:1.118
--- src/sys/dev/usb/ucom.c:1.117 Sun Dec 4 10:12:35 2016
+++ src/sys/dev/usb/ucom.c Wed Dec 14 15:11:29 2016
@@ -1,4 +1,4 @@
-/* $NetBSD: ucom.c,v 1.117 2016/12/04 10:12:35 skrll Exp $ */
+/* $NetBSD: ucom.c,v 1.118 2016/12/14 15:11:29 skrll Exp $ */
/*
* Copyright (c) 1998, 2000 The NetBSD Foundation, Inc.
@@ -34,7 +34,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ucom.c,v 1.117 2016/12/04 10:12:35 skrll Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ucom.c,v 1.118 2016/12/14 15:11:29 skrll Exp $");
#ifdef _KERNEL_OPT
#include "opt_usb.h"
@@ -1608,6 +1608,7 @@ ucomreadcb(struct usbd_xfer *xfer, void
return;
}
+ mutex_exit(&sc->sc_lock);
if (sc->sc_methods->ucom_read != NULL) {
sc->sc_methods->ucom_read(sc->sc_parent, sc->sc_portno,
&cp, &cc);
@@ -1617,6 +1618,15 @@ ucomreadcb(struct usbd_xfer *xfer, void
ub->ub_len = cc;
+ mutex_enter(&sc->sc_lock);
+ if (sc->sc_dying) {
+ if (--sc->sc_refcnt < 0)
+ cv_broadcast(&sc->sc_detachcv);
+ mutex_exit(&sc->sc_lock);
+ DPRINTF("... dying", 0, 0, 0, 0);
+ return;
+ }
+
SIMPLEQ_INSERT_TAIL(&sc->sc_ibuff_full, ub, ub_link);
ucom_read_complete(sc);
