Module Name: src Committed By: martin Date: Sun Mar 26 12:38:24 UTC 2017
Modified Files: src/sys/arch/sparc/sparc: openfirm.c Log Message: Add KASSERTs to catch access to NULL OF nodes early To generate a diff of this commit: cvs rdiff -u -r1.22 -r1.23 src/sys/arch/sparc/sparc/openfirm.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Modified files: Index: src/sys/arch/sparc/sparc/openfirm.c diff -u src/sys/arch/sparc/sparc/openfirm.c:1.22 src/sys/arch/sparc/sparc/openfirm.c:1.23 --- src/sys/arch/sparc/sparc/openfirm.c:1.22 Thu Apr 7 19:46:39 2016 +++ src/sys/arch/sparc/sparc/openfirm.c Sun Mar 26 12:38:24 2017 @@ -1,4 +1,4 @@ -/* $NetBSD: openfirm.c,v 1.22 2016/04/07 19:46:39 palle Exp $ */ +/* $NetBSD: openfirm.c,v 1.23 2017/03/26 12:38:24 martin Exp $ */ /* * Copyright (C) 1995, 1996 Wolfgang Solfrank. @@ -32,7 +32,7 @@ */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: openfirm.c,v 1.22 2016/04/07 19:46:39 palle Exp $"); +__KERNEL_RCSID(0, "$NetBSD: openfirm.c,v 1.23 2017/03/26 12:38:24 martin Exp $"); #include <sys/param.h> #include <sys/systm.h> @@ -166,6 +166,7 @@ OF_getproplen(int handle, const char *pr cell_t size; } args; + KASSERT(handle != 0); args.name = ADR2CELL("getproplen"); args.nargs = 2; args.nreturns = 1; @@ -190,6 +191,7 @@ OF_getprop(int handle, const char *prop, cell_t size; } args; + KASSERT(handle != 0); if (buflen > NBPG) return -1; args.name = ADR2CELL("getprop");