Module Name: src
Committed By: jdolecek
Date: Tue Aug 29 13:38:38 UTC 2017
Modified Files:
src/sys/dev/ata [jdolecek-ncq]: TODO.ncq
Log Message:
some notes around c_start/atastart()
To generate a diff of this commit:
cvs rdiff -u -r1.1.2.36 -r1.1.2.37 src/sys/dev/ata/TODO.ncq
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/ata/TODO.ncq
diff -u src/sys/dev/ata/TODO.ncq:1.1.2.36 src/sys/dev/ata/TODO.ncq:1.1.2.37
--- src/sys/dev/ata/TODO.ncq:1.1.2.36 Sun Aug 13 11:46:32 2017
+++ src/sys/dev/ata/TODO.ncq Tue Aug 29 13:38:38 2017
@@ -2,6 +2,11 @@ Bugs
----
test wd* at umass?, confirm the ata_channel kludge works
+c_start() needs to be called on splbio to avoid spurious irq during reset,
+is not e.g. in ata thread and may not in atastart() neither
+- wdc.c never calls atastart() (start always false)
+- ata_wdc.c calls atastart() regardless if error
+
Other random notes (do outside the NCQ branch):
-----------------------------------------------------
do biodone() in wddone() starting the dump to not leak bufs when dumping from
