Module Name:    src
Committed By:   riastradh
Date:           Sun Oct 29 17:57:21 UTC 2017

Modified Files:
        src/sys/dev: sequencer.c

Log Message:
Provisionally return to declaring midi_cd unconditionally.

Apparently this breaks compiling some kernels, although how they ever
managed to link if midi_cd is not declared in ioconf.h, and therefore
presumably not defined in ioconf.c, is beyond me.

Maybe someone who knows how sequencer is supposed to work, and/or
someone who knows how arm kernels are linked, can figure this out...


To generate a diff of this commit:
cvs rdiff -u -r1.69 -r1.70 src/sys/dev/sequencer.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/dev/sequencer.c
diff -u src/sys/dev/sequencer.c:1.69 src/sys/dev/sequencer.c:1.70
--- src/sys/dev/sequencer.c:1.69	Sat Oct 28 04:16:04 2017
+++ src/sys/dev/sequencer.c	Sun Oct 29 17:57:21 2017
@@ -1,4 +1,4 @@
-/*	$NetBSD: sequencer.c,v 1.69 2017/10/28 04:16:04 riastradh Exp $	*/
+/*	$NetBSD: sequencer.c,v 1.70 2017/10/29 17:57:21 riastradh Exp $	*/
 
 /*
  * Copyright (c) 1998, 2008 The NetBSD Foundation, Inc.
@@ -55,7 +55,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: sequencer.c,v 1.69 2017/10/28 04:16:04 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: sequencer.c,v 1.70 2017/10/29 17:57:21 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "sequencer.h"
@@ -99,9 +99,13 @@ __KERNEL_RCSID(0, "$NetBSD: sequencer.c,
  *
  * XXX XXX XXX Apparently sequencer.ioconf doesn't actually make the
  * sequencer cdev!  Did this ever work?
+ *
+ * XXX XXX XXX Apparently there are even some kernels that include a
+ * sequencer pseudo-device but exclude any midi device.  How do they
+ * even link??
  */
-#ifdef _MODULE
 extern struct cfdriver midi_cd;
+#ifdef _MODULE
 extern struct cfdriver sequencer_cd;
 #endif
 

Reply via email to