Module Name: src
Committed By: maxv
Date: Mon Jan 29 08:14:54 UTC 2018
Modified Files:
src/sys/netinet6: ip6_forward.c
Log Message:
Fix two pretty bad mistakes. If ipsec6_check_policy fails m is not freed,
and a 'goto out' is missing after ipsec6_process_packet.
To generate a diff of this commit:
cvs rdiff -u -r1.90 -r1.91 src/sys/netinet6/ip6_forward.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/netinet6/ip6_forward.c
diff -u src/sys/netinet6/ip6_forward.c:1.90 src/sys/netinet6/ip6_forward.c:1.91
--- src/sys/netinet6/ip6_forward.c:1.90 Tue Jan 9 04:41:19 2018
+++ src/sys/netinet6/ip6_forward.c Mon Jan 29 08:14:54 2018
@@ -1,4 +1,4 @@
-/* $NetBSD: ip6_forward.c,v 1.90 2018/01/09 04:41:19 ozaki-r Exp $ */
+/* $NetBSD: ip6_forward.c,v 1.91 2018/01/29 08:14:54 maxv Exp $ */
/* $KAME: ip6_forward.c,v 1.109 2002/09/11 08:10:17 sakane Exp $ */
/*
@@ -31,7 +31,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ip6_forward.c,v 1.90 2018/01/09 04:41:19 ozaki-r Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ip6_forward.c,v 1.91 2018/01/29 08:14:54 maxv Exp $");
#ifdef _KERNEL_OPT
#include "opt_gateway.h"
@@ -197,6 +197,7 @@ ip6_forward(struct mbuf *m, int srcrt)
*/
if (error == -EINVAL)
error = 0;
+ m_freem(m);
goto freecopy;
}
}
@@ -268,8 +269,10 @@ ip6_forward(struct mbuf *m, int srcrt)
int s = splsoftnet();
error = ipsec6_process_packet(m, sp->req);
splx(s);
+ /* m is freed */
if (mcopy)
goto freecopy;
+ goto out;
}
#endif
