Module Name: src
Committed By: maxv
Date: Thu Mar 1 16:49:07 UTC 2018
Modified Files:
src/sys/arch/x86/x86: svs.c
Log Message:
Remove these two KASSERTs. Thinking about it, they may fire when the user
enters "sysctl -w machdep.svs.enabled=0", if the xcall is received between
the 'svs_enabled' check in the caller and the same check in these KASSERTs.
In such a case we perform an SVS operation with svs_enabled set to false,
but that's intentional: after it is done svs_pmap_sync and svs_lwp_switch
won't be called anymore, the pdir synchronization is dropped.
Having said that, I didn't see these KASSERTs getting triggered.
To generate a diff of this commit:
cvs rdiff -u -r1.12 -r1.13 src/sys/arch/x86/x86/svs.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/arch/x86/x86/svs.c
diff -u src/sys/arch/x86/x86/svs.c:1.12 src/sys/arch/x86/x86/svs.c:1.13
--- src/sys/arch/x86/x86/svs.c:1.12 Sun Feb 25 13:15:35 2018
+++ src/sys/arch/x86/x86/svs.c Thu Mar 1 16:49:06 2018
@@ -1,4 +1,4 @@
-/* $NetBSD: svs.c,v 1.12 2018/02/25 13:15:35 maxv Exp $ */
+/* $NetBSD: svs.c,v 1.13 2018/03/01 16:49:06 maxv Exp $ */
/*
* Copyright (c) 2018 The NetBSD Foundation, Inc.
@@ -30,7 +30,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: svs.c,v 1.12 2018/02/25 13:15:35 maxv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: svs.c,v 1.13 2018/03/01 16:49:06 maxv Exp $");
#include "opt_svs.h"
@@ -455,7 +455,6 @@ svs_pmap_sync(struct pmap *pmap, int ind
struct cpu_info *ci;
cpuid_t cid;
- KASSERT(svs_enabled);
KASSERT(pmap != NULL);
KASSERT(pmap != pmap_kernel());
KASSERT(mutex_owned(pmap->pm_lock));
@@ -488,8 +487,6 @@ svs_lwp_switch(struct lwp *oldlwp, struc
uintptr_t rsp0;
vaddr_t va;
- KASSERT(svs_enabled);
-
if (newlwp->l_flag & LW_SYSTEM) {
return;
}
