Module Name: src
Committed By: maxv
Date: Thu Mar 29 17:09:00 UTC 2018
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
Fix memory leak, we may reallocate 'tcp_saveti' after 'findpcb'. It's not
a tragic bug, because it happens only on sockets with debug enabled.
To generate a diff of this commit:
cvs rdiff -u -r1.396 -r1.397 src/sys/netinet/tcp_input.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/netinet/tcp_input.c
diff -u src/sys/netinet/tcp_input.c:1.396 src/sys/netinet/tcp_input.c:1.397
--- src/sys/netinet/tcp_input.c:1.396 Thu Mar 29 17:01:46 2018
+++ src/sys/netinet/tcp_input.c Thu Mar 29 17:09:00 2018
@@ -1,4 +1,4 @@
-/* $NetBSD: tcp_input.c,v 1.396 2018/03/29 17:01:46 maxv Exp $ */
+/* $NetBSD: tcp_input.c,v 1.397 2018/03/29 17:09:00 maxv Exp $ */
/*
* Copyright (C) 1995, 1996, 1997, and 1998 WIDE Project.
@@ -148,7 +148,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: tcp_input.c,v 1.396 2018/03/29 17:01:46 maxv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: tcp_input.c,v 1.397 2018/03/29 17:09:00 maxv Exp $");
#ifdef _KERNEL_OPT
#include "opt_inet.h"
@@ -2348,6 +2348,8 @@ after_listen:
SEQ_GT(th->th_seq, tp->rcv_nxt)) {
tp = tcp_close(tp);
tcp_fields_to_net(th);
+ m_freem(tcp_saveti);
+ tcp_saveti = NULL;
goto findpcb;
}
