Module Name: src
Committed By: maxv
Date: Wed Apr 11 06:37:32 UTC 2018
Modified Files:
src/sys/netmpls: mpls_ttl.c
Log Message:
Add one more XXX in the list.
To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/sys/netmpls/mpls_ttl.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/netmpls/mpls_ttl.c
diff -u src/sys/netmpls/mpls_ttl.c:1.11 src/sys/netmpls/mpls_ttl.c:1.12
--- src/sys/netmpls/mpls_ttl.c:1.11 Fri Jan 19 14:15:35 2018
+++ src/sys/netmpls/mpls_ttl.c Wed Apr 11 06:37:32 2018
@@ -1,4 +1,4 @@
-/* $NetBSD: mpls_ttl.c,v 1.11 2018/01/19 14:15:35 maxv Exp $ */
+/* $NetBSD: mpls_ttl.c,v 1.12 2018/04/11 06:37:32 maxv Exp $ */
/*
* Copyright (c) 2010 The NetBSD Foundation, Inc.
@@ -97,7 +97,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: mpls_ttl.c,v 1.11 2018/01/19 14:15:35 maxv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: mpls_ttl.c,v 1.12 2018/04/11 06:37:32 maxv Exp $");
#ifdef _KERNEL_OPT
#include "opt_inet.h"
@@ -146,10 +146,12 @@ static struct mbuf *ip4_check(struct mbu
/*
* Send an ICMP Extended error message. References: RFC4884 and RFC4950.
*
- * This should be in sync with icmp_error() in sys/netinet/ip_icmp.c
- * XXX: is called only for ICMP_TIMXCEED_INTRANS but code is too general.
+ * XXX: This code is inspired from icmp_error(), and should really be merged
+ * into it. icmp_error() should handle ICMP Extended error messages.
*
- * XXX We're not setting the 'length' field of the Extended ICMP header.
+ * XXX: It is called only for ICMP_TIMXCEED_INTRANS but code is too general.
+ *
+ * XXX: We're not setting the 'length' field of the Extended ICMP header.
* According to RFC4884, we are in 'non-compliant' mode. Moreover, we're
* not computing the checksum of the Extended ICMP header.
*/
