Module Name: src
Committed By: msaitoh
Date: Wed May 23 04:45:24 UTC 2018
Modified Files:
src/sys/dev/pci/ixgbe: ix_txrx.c
Log Message:
Don't check IFF_RUNNING in ixgbe_rxeof(). Doing break and leaving a deacriptor
with DD bit is worse than just processing the entry. And it's also racy to
check IFF_RUNNING in rxeof(). If you'd like to strictly obey IFF_RUNNING,
it would be better to do it in the upper layer.
Same as DragonFly (a part of 79251f5ebe4cf9dd2f3e6aed590e09d756d39922).
To generate a diff of this commit:
cvs rdiff -u -r1.45 -r1.46 src/sys/dev/pci/ixgbe/ix_txrx.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/pci/ixgbe/ix_txrx.c
diff -u src/sys/dev/pci/ixgbe/ix_txrx.c:1.45 src/sys/dev/pci/ixgbe/ix_txrx.c:1.46
--- src/sys/dev/pci/ixgbe/ix_txrx.c:1.45 Fri May 18 10:09:02 2018
+++ src/sys/dev/pci/ixgbe/ix_txrx.c Wed May 23 04:45:24 2018
@@ -1,4 +1,4 @@
-/* $NetBSD: ix_txrx.c,v 1.45 2018/05/18 10:09:02 msaitoh Exp $ */
+/* $NetBSD: ix_txrx.c,v 1.46 2018/05/23 04:45:24 msaitoh Exp $ */
/******************************************************************************
@@ -1833,8 +1833,6 @@ ixgbe_rxeof(struct ix_queue *que)
if ((staterr & IXGBE_RXD_STAT_DD) == 0)
break;
- if ((ifp->if_flags & IFF_RUNNING) == 0)
- break;
count--;
sendmp = NULL;
