Module Name: src Committed By: snj Date: Sun Mar 28 16:21:18 UTC 2010
Modified Files: src/sys/dev/ic [netbsd-5]: ahcisata_core.c Log Message: Pull up following revision(s) (requested by bouyer in ticket #1317): sys/dev/ic/ahcisata_core.c: revision 1.23, 1.24 Move ahci_channel_start() after BSY has cleared (what seems to matter here is not touching SError while BSY is asserted). Fix random behavior (serial console corruption/misfunction, misbehavior of USB controllers, crasy interrupts crashing the Xen hypervisor, ...) of Intel ESB2 controller with some brand of hitachi drives. -- ahcisata_core.c 1.23 cause long drive probe (31s, reported by Roy Marples), or other devices misbehavior probably due to interrupts issues (reported by Jukka Ruohonen). Back it out and do the following changes: - clear port interrupt register before ahci_channel_start() which enables interrupts - wait 500ms after sata_reset_interface() before touching SERROR register. This is what seems to fix the issue I'm seeming on ESB2 controller. - The 31s delay didn't cause the probe to fail because of a mismatch in loop index comparison; use a #define for delay after reset instead of numeric values, to avoid this kind of bugs in the future. To generate a diff of this commit: cvs rdiff -u -r1.18.4.3 -r1.18.4.4 src/sys/dev/ic/ahcisata_core.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.