Module Name: src Committed By: rillig Date: Thu Sep 24 07:11:29 UTC 2020
Modified Files: src/usr.bin/make: compat.c dir.c job.c lst.c lst.h main.c make.c meta.c parse.c suff.c targ.c Log Message: make(1): rename Lst_ForEach to Lst_ForEachUntil Since the callback function returns a terminating condition, this is not really a foreach loop. Many of the calls to Lst_ForEachUntil don't make use of the terminating condition, and several don't modify the list structurally, which means they don't need this complicated implementation. In a follow-up commit, Lst_ForEach will be added back with a much simpler implementation that iterates over the list naively, without a terminating condition and without taking the iteration state from Lst_Open/Lst_Next/Lst_Close into account. The migration to this simpler implementation will be done step by step since each callback function needs to be examined closely. To generate a diff of this commit: cvs rdiff -u -r1.149 -r1.150 src/usr.bin/make/compat.c cvs rdiff -u -r1.144 -r1.145 src/usr.bin/make/dir.c cvs rdiff -u -r1.236 -r1.237 src/usr.bin/make/job.c cvs rdiff -u -r1.66 -r1.67 src/usr.bin/make/lst.c cvs rdiff -u -r1.63 -r1.64 src/usr.bin/make/lst.h cvs rdiff -u -r1.341 -r1.342 src/usr.bin/make/main.c cvs rdiff -u -r1.139 -r1.140 src/usr.bin/make/make.c cvs rdiff -u -r1.117 -r1.118 src/usr.bin/make/meta.c cvs rdiff -u -r1.323 -r1.324 src/usr.bin/make/parse.c cvs rdiff -u -r1.158 -r1.159 src/usr.bin/make/suff.c cvs rdiff -u -r1.91 -r1.92 src/usr.bin/make/targ.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.