Module Name:    src
Committed By:   rillig
Date:           Tue Feb  2 17:56:31 UTC 2021

Modified Files:
        src/usr.bin/make: enum.c enum.h make.c nonints.h targ.c
        src/usr.bin/make/unit-tests: gnode-submake.exp opt-debug-graph1.exp
            opt-debug-graph2.exp opt-debug-graph3.exp suff-incomplete.exp
            suff-main-several.exp suff-transform-debug.exp

Log Message:
make: remove overengineered Enum_ValueToString

For printing the status of a GNode, there was already made_name (now
renamed to GNodeMade_Name), which prints user-friendly text instead of
the bare enum constant names.

To do this change confidently, I first had to demonstrate that the
output really affects something other than just the word "UNMADE". There
had not been a test for that case before, and the test immediately
discovered a bug in the -dg2 and -dg3 options.  This bug is one of the
oldest in make, dating back to at least 1993.


To generate a diff of this commit:
cvs rdiff -u -r1.14 -r1.15 src/usr.bin/make/enum.c
cvs rdiff -u -r1.16 -r1.17 src/usr.bin/make/enum.h
cvs rdiff -u -r1.238 -r1.239 src/usr.bin/make/make.c
cvs rdiff -u -r1.189 -r1.190 src/usr.bin/make/nonints.h
cvs rdiff -u -r1.160 -r1.161 src/usr.bin/make/targ.c
cvs rdiff -u -r1.1 -r1.2 src/usr.bin/make/unit-tests/gnode-submake.exp
cvs rdiff -u -r1.8 -r1.9 src/usr.bin/make/unit-tests/opt-debug-graph1.exp
cvs rdiff -u -r1.3 -r1.4 src/usr.bin/make/unit-tests/opt-debug-graph2.exp \
    src/usr.bin/make/unit-tests/opt-debug-graph3.exp \
    src/usr.bin/make/unit-tests/suff-incomplete.exp \
    src/usr.bin/make/unit-tests/suff-transform-debug.exp
cvs rdiff -u -r1.4 -r1.5 src/usr.bin/make/unit-tests/suff-main-several.exp

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Reply via email to