Module Name: src Committed By: rillig Date: Wed Jun 16 03:56:59 UTC 2021
Modified Files: src/usr.bin/make: job.c Log Message: make: extract commands-ok check from JobWriteShellCommands This piece of code did not match the function name and thus could not reasonably be expected in that function. In job.c 1.399 from 2021-01-29 I missed exactly this little detail when I added code to skip the apparently unnecessary creation of empty shell files. The code I added only handled the happy case, not the case where the target could not be made. That code path then differed, leading to a much more verbose error message than before. before: don't know how to make ../missing/no-such.o. Stop after: don't know how to make ../missing/no-such.o. Stop ... `../missing/no-such.o' was not built (made BEINGMADE, ...)! `muck' was not built (made DEFERRED, type OP_DEPENDS|...)! `muck' has .ORDER dependency against build-all (made DEFERRED, ...) Thanks to sjg for finding and reproducing this unintended change of behavior. To generate a diff of this commit: cvs rdiff -u -r1.433 -r1.434 src/usr.bin/make/job.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.