Module Name: src Committed By: marty Date: Sat Dec 19 21:42:31 UTC 2015
Modified Files: src/sys/arch/arm/samsung: exynos_gpio.c exynos_var.h files.exynos src/sys/arch/evbarm/conf: EXYNOS Added Files: src/sys/arch/arm/samsung: exynos_pinctrl.c Log Message: XU4 GPIO FDT broken snapshot This is broken. exynos_gpio_bank_config and the call to it are wrong, and the acquire function doesn't work. But I'm in over my head and I need to discuss this: There is a problem with the dtd: it doesn't have addresses for the individual gpios. Do I add the addresses to it, or go back to the old version where I have them hard coded in the driver. There is a problem with creating the gpio device entries: I suspect I really need to treat the pinctrl devices as busses and create the gpios as attached to those busses, but I'm not familiar with how to do that in NetBSD. At the minimum, a pointer to a similar situation would give me code to follow. This is different than the usual bus attachment in that the gpios aren't devices in the dtd (they don't have "compatible" properties) so they don't get an attach routine called. An alternative to generating the bus attachments might be to add "compatible" properties to the GPIO entries in the dtd. so that they do get attached in the normal way. If I'm going to modify the DTD, then it should be checked in, so a decision on where to check them in would be nice, even if it does mean spreading them all over because of license issues. (This DTD is GPL v2) To generate a diff of this commit: cvs rdiff -u -r1.13 -r1.14 src/sys/arch/arm/samsung/exynos_gpio.c \ src/sys/arch/arm/samsung/files.exynos cvs rdiff -u -r0 -r1.1 src/sys/arch/arm/samsung/exynos_pinctrl.c cvs rdiff -u -r1.20 -r1.21 src/sys/arch/arm/samsung/exynos_var.h cvs rdiff -u -r1.2 -r1.3 src/sys/arch/evbarm/conf/EXYNOS Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.