On Tue, Jul 21, 2009 at 05:49:36AM -0600, Henning Brauer wrote: > CVSROOT: /cvs > Module name: src > Changes by: henn...@cvs.openbsd.org 2009/07/21 05:49:36 > > Modified files: > usr.sbin/bgpctl: bgpctl.c > > Log message: > sorry, but showing a diff, getting an explicit "not ok" and then committing > anyway without oks is not our process >
And just saying I don't like it and reverting to a even worse diff is also not ok. Sorry but your reasoning here is wrong. You never could realy justify why you need to see the media state in bgpctl show nexthop when the same info is available in bgpctl show interface (where it belongs). Actually we have already ifconfig(8) which shows this info as well. So sure revert it, don't show the info people actually need to see to figure out why the hell all the traffic flows in the wrong direction, it seems it is more important to see the fluffy "UP, Ethernet, active, 100 MBit/s" repeated dozens of times. > bgpctl show next Nexthop State 192.0.2.126 valid rl2 UP, Ethernet, active, 100 MBit/s I just don't get it why almost 50% of a line is spent for redundant and unimportant information and what's so bad about: > bgpctl show next Nexthop Gateway State Interface Link State 192.0.2.1 connected valid fxp0 active 192.168.1.1 192.0.2.1 valid fxp0 active -- :wq Claudio
