Marc Espie <es...@nerim.net> wrote:

> On Mon, Oct 08, 2018 at 01:16:53PM -0600, Theo de Raadt wrote:
> > So it is likely to break something else also.
> > 
> > The change is dangerously late, so I recommend a backout.
> > 
> > Alexander Bluhm <alexander.bl...@gmx.net> wrote:
> > 
> > > On Sat, Oct 06, 2018 at 08:00:30AM -0600, Marc Espie wrote:
> > > > CVSROOT:        /cvs
> > > > Module name:    src
> > > > Changes by:     es...@cvs.openbsd.org   2018/10/06 08:00:30
> > > > 
> > > > Modified files:
> > > >         usr.bin/make   : suff.c 
> > > > 
> > > > Log message:
> > > > fix problem reported by markwes...@cock.li
> > > > 
> > > > specifically:
> > > > - suffix rules for the empty suffix shouldn't be prevented from 
> > > > triggering
> > > > by having dependencies.
> > > > 
> > > > but this exhibits another issue:
> > > > - .PHONY targets shouldn't trigger suffix rules.
> > > > 
> > > > (also clean up an utility function)
> > > > 
> > > > NetBSD make has got similar modernizations, but the code is entirely
> > > > different by now.
> > > > 
> > > > okay kn@, millert@
> > > 
> > > This commit broke regress/usr.bin/calendar and regress/usr.bin/mandoc.
> > > 
> > > bluhm
> > > 
> It actually went thru a full bulk build and a ports build and a source build
> and a release.
> 
> Let me see about the regress, please ?
> 

Obviously the behaviour changed.  And 10 days before lock.

the word is hubris....

Reply via email to