CVSROOT: /cvs
Module name: src
Changes by: t...@cvs.openbsd.org 2018/10/16 14:06:42
Modified files:
games/banner : banner.c
Log message:
More fixes from David Fifield:
First, fill a missing pixel in the glyph for 'U'.
Second, fix an off-by-one in the line output routine. This caused an
extra space character to be output at the end of every line. It might
have caused a buffer overflow if any glyph had used the entire possible
width of 132 pixels, but as it is the widest is only 124 pixels.
Third, output blank lines instead of lines full of spaces (the number of
spaces was equal to the width of the most recent non-blank line).
Finally, add bounds checks to protect against buffer overflows that could arise
in case the data table were ever modified to draw out of bounds (characters
wider or taller than 132 pixels, or a two-byte code where the second byte is
past the end of the table).
ok bcallah
