CVSROOT: /cvs
Module name: src
Changes by: d...@cvs.openbsd.org 2019/01/29 20:08:12
Modified files:
gnu/llvm/include/llvm/BinaryFormat: Dwarf.def
gnu/llvm/lib/Target/X86: X86.td X86FrameLowering.cpp
X86FrameLowering.h
X86MachineFunctionInfo.h X86Subtarget.h
gnu/llvm/tools/clang/include/clang/Driver: Options.td
gnu/llvm/tools/clang/lib/Basic/Targets: X86.cpp X86.h
Log message:
implement -msave-args in clang/llvm, like the sun did for gcc
this is a bit different to gcc as gcc likes to use movs to move
stuff on and off the stack, and directly updates the stack pointers
with add and sub instructions. llvm prefers to use push and pop
instructions, is a lot more careful about keeping track of how
much stuff is currently on the stack, and generally pops the frame
pointer rather than do maths on it.
-msave-args adds a bunch of pushes as the first thing a function
prologue does. to keep the stack aligned, if there's an odd number
of arguments to the function it pushes the first one again to put
the frame back on a 16 byte boundary.
to undo the pushes the frame pointer needs to be updated in function
epilogues. clang emits a series of pops to fix up the registers on
the way out, but popping saved arguments is a waste of time and
harmful to actual data in the function. rather than add an offset
to the stack pointer, -msave-args emits a leaveq operation to fix
up the frame again. leaveq is effectively mov rbp,rsp; pop rbp, and
is a single byte, meaning there's less potential for gadgets compared
to a direct add to rsp, or an explicit mov rbp,rsp.
the only thing missing compared to the gcc implementation is adding
the SUN_amd64_parmdump dwarf flag to affected functions. if someone
can tell me how to add that from the frame lowering code, let me
know.
when enabled in kernel builds again, this will provide useful
arguments in ddb stack traces again.
