CVSROOT: /cvs Module name: src Changes by: mes...@cvs.openbsd.org 2019/04/30 12:28:45
Modified files: usr.bin/chpass : chpass.c Log message: add unveil(2): chpass(1) without parameters enters in edit mode by default, in here it will need to execute _PATH_BSHELL to spawn a new EDITOR, _PATH_SHELLS to check (read) if we are changing from/to a non-standard shell (in case we are not root) and read access to `tempname' to verify if the file has valid entries and create to unlink it. If -s is used to change a user's shell then it will need read access to _PATH_SHELLS by the same reason already mentioned above. Unconditionally we need to unveil _PATH_MASTERPASSWD_LOCK with write/create permissions, _PATH_MASTERPASSWD with read and _PATH_PWD_MKDB to execute pwd_mkdb(8). In the -a case I'm not unveiling /etc/spwd.db since we can get it through pledge "getpw", which can be added later for completeness of all code paths. Note also that the first pledges need "unveil" since we will call unveil(2) afterwards. "looks good" deraadt@