On Fri, May 29, 2020 at 03:02:44AM -0600, Darren Tucker wrote:
> CVSROOT: /cvs
> Module name: src
> Changes by: dtuc...@cvs.openbsd.org 2020/05/29 03:02:44
>
> Modified files:
> usr.bin/ssh : misc.c
>
> Log message:
> Pass a NULL instead of zeroed out va_list from dollar_expand. The original
> intent was in case there's some platform where va_list is not a pointer
> equivalent, but on i386 this chokes on the memset. This unbreaks that
> build, but will require further consideration.
>
This fails on arm64:
/usr/src/usr.bin/ssh/ssh/../misc.c:1181:51: error: passing 'void *' to
parameter of incompatible type
'va_list' (aka '__builtin_va_list')
ret = vdollar_percent_expand(&err, 1, 0, string, NULL);
^~~~
/usr/include/sys/_null.h:10:14: note: expanded from macro 'NULL'
#define NULL ((void *)0)
^~~~~~~~~~~
/usr/src/usr.bin/ssh/ssh/../misc.c:1060:33: note: passing argument to
parameter 'ap' here
const char *string, va_list ap)
^
1 error generated.
