On Thu, Sep 03, 2020 at 07:13:53AM +0200, Otto Moerbeek wrote: > On Wed, Sep 02, 2020 at 10:19:53PM -0600, Theo Buehler wrote: > > > CVSROOT: /cvs > > Module name: src > > Changes by: t...@cvs.openbsd.org 2020/09/02 22:19:53 > > > > Modified files: > > usr.bin/yacc : output.c > > > > Log message: > > Switch use of '\0' to NULL > > > > Fix a clang 10 warning about comparing a pointer to a null character. The > > condition "if ((s = symnam[i]) == '\0')" used to be "if (s = symnam[i])" > > and the incorrect spelling of NULL was chosen in a -Wall cleanup 19 years > > ago (-r 1.6). Upstream uses a naked 0 instead of NULL, so does NetBSD. > > > > ok martijn millert > > That's a typo in the commit message... Now it looks as if the condition > was reversed.
Argh. Sorry about that. Of course it was != '\0', not == '\0'. I should not write commit messages before coffee... > > -Otto >
