CVSROOT: /cvs
Module name: src
Changes by: schwa...@cvs.openbsd.org 2021/08/12 04:31:15
Modified files:
lib/libedit : editline.3 read.c
Log message:
Stop playing hopeless games with FIONBIO.
If the calling program sets this flag, that is (1) either a bug
(or at least needless) (2) or clearing it in el_wgets(3) will break
other functionality of the calling program if it really requires it.
In both cases, treating EAGAIN as a fatal error in el_wgets(3) is
better than brushing the issue under the carpet: at least it tells
the program author that something is amiss.
Instead of attempting automatic repairs that will almost never do
the right thing, clearly state in the manual page that the editline(3)
library is not designed to work with non-blocking I/O.
The problem was found while investigating a bug report
from deraadt@ in sftp(1).
OK millert@ and "mostly OK" martijn@
