On Wed, Apr 06, 2022 at 12:59:30PM -0600, Christian Weisgerber wrote: > CVSROOT: /cvs > Module name: src > Changes by: na...@cvs.openbsd.org 2022/04/06 12:59:30 > > Modified files: > sys/arch/arm64/dev: acpiiort.c apldart.c apldog.c aplhidev.c > aplintc.c aplns.c aplpcie.c aplpinctrl.c > aplpmu.c aplspi.c aplspmi.c smmu_acpi.c > smmu_fdt.c > sys/arch/armv7/omap: omclock.c omcm.c omrng.c omsysc.c > sys/arch/landisk/dev: obio.c power.c wdc_obio.c > sys/arch/landisk/landisk: mainbus.c > sys/arch/loongson/dev: apm.c gdiumiic.c glxclk.c mcclock_isa.c > ohci_voyager.c > sys/arch/luna88k/cbus: i82365_cbus.c if_ne_cbus.c necsb.c > sys/arch/luna88k/dev: spc.c timekeeper.c > sys/arch/macppc/dev: if_mc.c > sys/arch/mips64/mips64: clock.c cpu.c > sys/arch/octeon/dev: amdcf.c cn30xxgmx.c cn30xxuart.c octcf.c > octeon_iobus.c octrng.c octrtc.c > sys/arch/powerpc64/dev: astfb.c ipmi_opal.c mainbus.c opal.c > opalcons.c opalsens.c phb.c xicp.c > xics.c xive.c > sys/arch/powerpc64/powerpc64: cpu.c > sys/arch/riscv64/dev: plic.c riscv_cpu_intc.c sfclock.c sfuart.c > simplebus.c > sys/arch/riscv64/riscv64: cpu.c > sys/arch/sh/dev: scif.c shb.c shpcic.c > sys/arch/sh/sh : cpu.c > sys/dev : ipmi.c midi.c radio.c rd.c softraid.c video.c > vscsi.c > sys/dev/acpi : abl.c acpiac.c acpiasus.c acpibat.c acpibtn.c > acpicbkbd.c acpicmos.c acpicpu.c acpidmar.c > acpidock.c acpiec.c acpige.c acpihid.c > acpihpet.c acpihve.c acpimadt.c acpimcfg.c > acpiprt.c acpipwrres.c acpisony.c acpisurface.c > acpithinkpad.c acpitimer.c acpitoshiba.c > acpitz.c acpivideo.c acpivout.c ahci_acpi.c > amdgpio.c aplgpio.c atk0110.c bytgpio.c > ccp_acpi.c ccpmic.c chvgpio.c com_acpi.c > dwgpio.c dwiic_acpi.c ehci_acpi.c glkgpio.c > if_bse_acpi.c imxiic_acpi.c ipmi_acpi.c > ohci_acpi.c pchgpio.c pluart_acpi.c sdhc_acpi.c > tipmic.c tpm.c xhci_acpi.c > sys/dev/adb : akbd.c ams.c > sys/dev/ata : wd.c > sys/dev/atapiscsi: atapiscsi.c > sys/dev/cardbus: cardbus.c cardslot.c com_cardbus.c > ehci_cardbus.c if_acx_cardbus.c > if_ath_cardbus.c if_athn_cardbus.c > if_atw_cardbus.c if_bwi_cardbus.c > if_dc_cardbus.c if_fxp_cardbus.c > if_malo_cardbus.c if_pgt_cardbus.c > if_ral_cardbus.c if_re_cardbus.c > if_rl_cardbus.c if_rtw_cardbus.c > if_xl_cardbus.c ohci_cardbus.c puc_cardbus.c > uhci_cardbus.c > sys/dev/eisa : ahc_eisa.c cac_eisa.c eisa.c if_ep_eisa.c > uha_eisa.c > sys/dev/fdt : amlpwrc.c bcm2711_pcie.c bcm2711_rng.c > bcm2711_tmon.c bcm2835_bsc.c bcm2835_clock.c > bcm2835_dmac.c bcm2835_gpio.c bcm2835_mbox.c > bcm2835_sdhost.c bd718x7.c cwfg.c dapmic.c > es8316ac.c exuart.c gfrtc.c gpiocharger.c > gpioleds.c graphaudio.c if_bse_fdt.c if_mvpp.c > iicmux.c imxdog.c imxdwusb.c imxehci.c > imxiic_fdt.c imxpciephy.c imxpwm.c ipmi_fdt.c > mvkpcie.c mvsw.c ociic.c pciecam.c rkanxdp.c > rkdrm.c rkdwhdmi.c rkiis.c rkrng.c rktcphy.c > rkvop.c simpleamp.c simpleaudio.c tcpci.c > sys/dev/gpio : gpio.c gpioiic.c gpioow.c gpiosim.c > sys/dev/hil : hilid.c hilkbd.c hilms.c > sys/dev/i2c : abx80x.c ad741x.c adm1021.c adm1024.c adm1025.c > adm1026.c adm1030.c adm1031.c adt7460.c > adt7462.c asb100.c asc7611.c asc7621.c bmc150.c > ds1307.c ds1631.c ds3231.c fcu.c fintek.c > gl518sm.c i2c.c iatp.c ihidev.c ipmi_i2c.c > isl1208.c lis331dl.c lm75.c lm78_i2c.c lm87.c > lm93.c maxim6690.c mcp794xx.c pca9532.c > pca9548.c pca9554.c pcf85063.c pcf8523.c > pcf8563.c rs5c372.c sdtemp.c spdmem_i2c.c > thmc50.c tmp451.c tsl2560.c w83793g.c w83795g.c > w83l784r.c > sys/dev/isa : addcom_isa.c aic_isa.c aic_isapnp.c aps.c ast.c > boca.c com_commulti.c com_isa.c com_isapnp.c > cy_isa.c ess_isapnp.c fd.c fdc.c fins.c > gscsio.c gus_isa.c gus_isapnp.c hsq.c > i82365_isa.c i82365_isapnp.c if_an_isapnp.c > if_ec.c if_ef_isapnp.c if_eg.c if_el.c > if_ep_isa.c if_ep_isapnp.c if_ex.c if_ie.c > if_lc_isa.c if_le_isa.c if_le_isapnp.c > if_ne_isa.c if_ne_isapnp.c if_sm_isa.c if_we.c > isa.c isadma.c isagpio.c isapnp.c it.c > lm78_isa.c lpt_isa.c mpu_isa.c mpu_isapnp.c > nsclpcsio_isa.c pas.c pcdisplay.c pcppi.c > sb_isa.c sb_isapnp.c sch311x.c skgpio.c spkr.c > tcic2_isa.c uguru.c uha_isa.c vga_isa.c > viasio.c wbsio.c wdc_isa.c wdc_isapnp.c wds.c > sys/dev/mii : acphy.c amphy.c atphy.c bmtphy.c brgphy.c > brswphy.c ciphy.c dcphy.c eephy.c etphy.c > exphy.c gentbi.c icsphy.c inphy.c iophy.c > ipgphy.c jmphy.c luphy.c lxtphy.c mlphy.c > mtdphy.c nsgphy.c nsphy.c nsphyter.c qsphy.c > rdcphy.c rgephy.c rlphy.c sqphy.c tlphy.c > tqphy.c txphy.c ukphy.c urlphy.c xmphy.c > sys/dev/onewire: onewire.c owctr.c owid.c owsbm.c owtemp.c > sys/dev/pci : com_pci.c if_aq_pci.c if_igc.c if_iwx.c > trm_pci.c > sys/dev/pckbc : pckbd.c pms.c > sys/dev/pcmcia : aic_pcmcia.c cfxga.c com_pcmcia.c > if_an_pcmcia.c if_ep_pcmcia.c if_malo.c > if_ne_pcmcia.c if_sm_pcmcia.c if_wi_pcmcia.c > if_xe.c pcmcia.c wdc_pcmcia.c > sys/dev/puc : com_puc.c lpt_puc.c > sys/dev/sdmmc : if_bwfm_sdio.c sdmmc.c > sys/dev/tc : asc_tc.c asc_tcds.c if_le_ioasic.c if_le_tc.c > tc.c tcds.c > sys/dev/wscons : wsdisplay.c wskbd.c wsmouse.c > > Log message: > constify struct cfattach
This broke the amd64 ramdisk, cc -g -Werror -Wall -Wimplicit-function-declaration -Wno-pointer-sign -Wframe-larger-than=2047 -Wno-address-of-packed-member -Wno-constant-conversion -Wno-unused-but-set-variable -Wno-gnu-folding-constant -mcmodel=kernel -mno-red-zone -mno-sse2 -mno-sse -mno-3dnow -mno-mmx -msoft-float -fno-omit-frame-pointer -ffreestanding -fno-pie -fno-stack-protector -mno-retpoline -Oz -pipe -nostdinc -I/home/src2/sys -I/home/src2/sys/arch/amd64/compile/RAMDISK_CD/obj -I/home/src2/sys/arch -I/home/src2/sys/dev/pci/drm/include -I/home/src2/sys/dev/pci/drm/include/uapi -I/home/src2/sys/dev/pci/drm/amd/include/asic_reg -I/home/src2/sys/dev/pci/drm/amd/include -I/home/src2/sys/dev/pci/drm/amd/amdgpu -I/home/src2/sys/dev/pci/drm/amd/display -I/home/src2/sys/dev/pci/drm/amd/display/include -I/home/src2/sys/dev/pci/drm/amd/display/dc -I/home/src2/sys/dev/pci/drm/amd/display/amdgpu_dm -I/home/src2/sys/dev/pci/drm/amd/pm/inc -I/home/src2/sys/dev/pci/drm/amd/pm/swsmu -I/home/src2/sys/dev/pci/drm/amd/pm/swsmu/smu11 -I/home/src2/sys/dev/pci/drm/amd/pm/swsmu/smu12 -I/home/src2/sys/dev/pci/drm/amd/pm/swsmu/smu13 -I/home/src2/sys/dev/pci/drm/amd/pm/powerplay -I/home/src2/sys/dev/pci/drm/amd/pm/powerplay/hwmgr -I/home/src2/sys/dev/pci/drm/amd/pm/powerplay/smumgr -I/home/src2/sys/dev/pci/drm/amd/display/dc/inc -I/home/src2/sys/dev/pci/drm/amd/display/dc/inc/hw -I/home/src2/sys/dev/pci/drm/amd/display/dc/clk_mgr -I/home/src2/sys/dev/pci/drm/amd/display/modules/inc -I/home/src2/sys/dev/pci/drm/amd/display/modules/hdcp -I/home/src2/sys/dev/pci/drm/amd/display/dmub/inc -I/home/src2/sys/dev/pci/drm/i915 -DSMALL_KERNEL -DNO_PROPOLICE -DBOOT_CONFIG -DPCIVERBOSE -DSCSITERSE -DFFS -DFFS2 -DEXT2FS -DNFSCLIENT -DCD9660 -DUDF -DMSDOSFS -DINET6 -DCRYPTO -DFONT_SPLEEN8x16 -DFONT_SPLEEN12x24 -DFONT_SPLEEN16x32 -DRAMDISK_HOOKS -DMINIROOTSIZE="0x1cc0" -DMAXUSERS=4 -D_KERNEL -MD -MP -c /home/src2/sys/dev/rd.c /home/src2/sys/dev/rd.c:87:15: error: assigning to 'struct cfattach *' from 'const struct cfattach *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] cf.cf_attach = &rd_ca; ^ ~~~~~~ 1 error generated. *** Error 1 in /home/src2/sys/arch/amd64/compile/RAMDISK_CD (Makefile:773 'rd.o') *** Error 1 in target 'rd.o' *** Error 2 in /home/src2/distrib/amd64/ramdisk_cd (Makefile:72 'bsd') *** Error 2 in /home/src2/distrib/amd64 (<bsd.subdir.mk>:48 'all') *** Error 2 in /home/src2/distrib (<bsd.subdir.mk>:48 'all') *** Error 2 in . (Makefile:301 'distrib') *** Error 2 in . (Makefile:277 'do-release') *** Error 2 in /home/src2/etc (Makefile:260 'release') robsd-exec: process group exited 2