On 13.4.2022. 19:22, Alexander Bluhm wrote: > On Fri, Apr 08, 2022 at 07:49:43PM -0600, Dave Voutila wrote: >> CVSROOT: /cvs >> Module name: src >> Changes by: d...@cvs.openbsd.org 2022/04/08 19:49:43 >> >> Modified files: >> sys/arch/amd64/amd64: vmm_support.S >> >> Log message: >> Simplify vmx instruction error handling. >> >> Removes jumps and shortens the code while keeping functionality the >> same. >> >> ok mlarkin@ > > This commit breaks vmm on my ThinkPad T430s. > > cpu1: failed to enter VMM mode > cpu0: failed to enter VMM mode > > cpu0: Intel(R) Core(TM) i7-3520M CPU @ 2.90GHz, 2893.83 MHz, 06-3a-09 > cpu0: > FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,FSGSBASE,SMEP,ERMS,MD_CLEAR,IBRS,IBPB,STIBP,L1DF,SSBD,SENSOR,ARAT,XSAVEOPT,MELTDOWN > cpu0: 256KB 64b/line 8-way L2 cache > > I think the problem is that XOR affects the zero flag. Does it? > This diff fixes it. >
Hi, I don't know if this commit broke things but i'm having same errors as bluhm@ and vm's doesn't come up . login: cpu9: failed to enter VMM mode cpu8: failed to enter VMM mode cpu7: failed to enter VMM mode cpu6: failed to enter VMM mode cpu5: failed to enter VMM mode cpu4: failed to enter VMM mode cpu3: failed to enter VMM mode cpu1: failed to enter VMM mode cpu2: failed to enter VMM mode cpu11: failed to enter VMM mode cpu10: failed to enter VMM mode cpu9: failed to enter VMM mode cpu8: failed to enter VMM mode cpu7: failed to enter VMM mode cpu6: failed to enter VMM mode cpu5: failed to enter VMM mode cpu4: failed to enter VMM mode cpu3: failed to enter VMM mode cpu2: failed to enter VMM mode cpu1: failed to enter VMM mode cpu0: failed to enter VMM mode smr: dispatch took 11.170215s cpu0: failed to enter VMM mode cpu11: failed to enter VMM mode cpu10: failed to enter VMM mode cpu9: failed to enter VMM mode cpu8: failed to enter VMM mode cpu7: failed to enter VMM mode cpu6: failed to enter VMM mode cpu5: failed to enter VMM mode cpu3: failed to enter VMM mode cpu2: failed to enter VMM mode cpu1: failed to enter VMM mode cpu4: failed to enter VMM mode cpu0: failed to enter VMM mode cpu11: failed to enter VMM mode cpu10: failed to enter VMM mode cpu9: failed to enter VMM mode cpu8: failed to enter VMM mode cpu7: failed to enter VMM mode cpu6: failed to enter VMM mode cpu4: failed to enter VMM mode cpu3: failed to enter VMM mode cpu2: failed to enter VMM mode cpu1: failed to enter VMM mode cpu5: failed to enter VMM mode
